Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-22664 Move protobuf stuff in hbase-rsgroup to hbase-protocol-sh… #362

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Jul 8, 2019

…aded

Copy link
Contributor

@infraio infraio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSGroupAdminEndpoint should import shaded proto?

public static HBaseProtos.TimeRange toTimeRange(TimeRange timeRange) {
if (timeRange == null) {
timeRange = TimeRange.allTime();
public static RSGroupProtos.RSGroupInfo toProtoGroupInfo(RSGroupInfo pojo) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method should be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least we still need it for now as it is referenced in lots of places. Not sure if we can remove it at the end. FWIW, I think we still need to support the old way to change rsgroup, which uses coprocessor endpoint?

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 23 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0 mvndep 24 Maven dependency ordering for branch
+1 mvninstall 245 master passed
+1 compile 105 master passed
+1 checkstyle 60 master passed
+1 shadedjars 268 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 321 master passed
+1 javadoc 63 master passed
_ Patch Compile Tests _
0 mvndep 16 Maven dependency ordering for patch
+1 mvninstall 241 the patch passed
+1 compile 104 the patch passed
+1 cc 104 the patch passed
+1 javac 104 the patch passed
+1 checkstyle 60 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedjars 269 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 761 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 hbaseprotoc 121 the patch passed
+1 findbugs 362 the patch passed
+1 javadoc 63 the patch passed
_ Other Tests _
+1 unit 37 hbase-protocol-shaded in the patch passed.
+1 unit 24 hbase-protocol in the patch passed.
+1 unit 109 hbase-client in the patch passed.
+1 unit 221 hbase-rsgroup in the patch passed.
+1 asflicense 46 The patch does not generate ASF License warnings.
3918
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/1/artifact/out/Dockerfile
GITHUB PR #362
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc xml
uname Linux 3dcf9ec97852 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 605f8a1
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/1/testReport/
Max. process+thread count 4602 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-protocol hbase-client hbase-rsgroup U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 52 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0 mvndep 30 Maven dependency ordering for branch
+1 mvninstall 275 master passed
+1 compile 103 master passed
+1 checkstyle 61 master passed
+1 shadedjars 270 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 327 master passed
+1 javadoc 68 master passed
_ Patch Compile Tests _
0 mvndep 16 Maven dependency ordering for patch
+1 mvninstall 237 the patch passed
+1 compile 104 the patch passed
+1 cc 104 the patch passed
+1 javac 104 the patch passed
+1 checkstyle 67 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 1 The patch has no ill-formed XML file.
+1 shadedjars 274 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 791 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 hbaseprotoc 122 the patch passed
+1 findbugs 353 the patch passed
+1 javadoc 60 the patch passed
_ Other Tests _
+1 unit 37 hbase-protocol-shaded in the patch passed.
+1 unit 25 hbase-protocol in the patch passed.
+1 unit 108 hbase-client in the patch passed.
-1 unit 574 hbase-rsgroup in the patch failed.
+1 asflicense 43 The patch does not generate ASF License warnings.
4386
Reason Tests
Failed junit tests hadoop.hbase.rsgroup.TestRSGroupsBalance
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/2/artifact/out/Dockerfile
GITHUB PR #362
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc xml
uname Linux 5bf55cae4981 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 605f8a1
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/2/artifact/out/patch-unit-hbase-rsgroup.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/2/testReport/
Max. process+thread count 4514 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-protocol hbase-client hbase-rsgroup U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 151 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0 mvndep 25 Maven dependency ordering for branch
+1 mvninstall 252 master passed
+1 compile 106 master passed
+1 checkstyle 69 master passed
+1 shadedjars 266 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 321 master passed
+1 javadoc 61 master passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 240 the patch passed
+1 compile 107 the patch passed
+1 cc 107 the patch passed
+1 javac 107 the patch passed
+1 checkstyle 65 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedjars 269 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 746 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 hbaseprotoc 108 the patch passed
+1 findbugs 399 the patch passed
+1 javadoc 57 the patch passed
_ Other Tests _
+1 unit 36 hbase-protocol-shaded in the patch passed.
+1 unit 25 hbase-protocol in the patch passed.
+1 unit 111 hbase-client in the patch passed.
+1 unit 463 hbase-rsgroup in the patch passed.
+1 asflicense 46 The patch does not generate ASF License warnings.
4298
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/3/artifact/out/Dockerfile
GITHUB PR #362
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc xml
uname Linux 6270fc02cad9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 605f8a1
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/3/testReport/
Max. process+thread count 4410 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-protocol hbase-client hbase-rsgroup U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor Author

Apache9 commented Jul 8, 2019

Any other concerns? @infraio
Thanks.

Copy link
Contributor

@infraio infraio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. The RSGroupAdmin.proto not be removed and just copied to shade protobuf module.
+1.

@Apache9 Apache9 changed the title HBASE-22664 Move protobuf sutff in hbase-rsgroup to hbase-protocol-sh… HBASE-22664 Move protobuf stuff in hbase-rsgroup to hbase-protocol-sh… Jul 9, 2019
@Apache9 Apache9 changed the base branch from master to HBASE-22514 July 9, 2019 01:50
@Apache9 Apache9 merged commit 83db672 into apache:HBASE-22514 Jul 9, 2019
asfgit pushed a commit that referenced this pull request Jul 11, 2019
asfgit pushed a commit that referenced this pull request Jul 14, 2019
asfgit pushed a commit that referenced this pull request Jul 16, 2019
asfgit pushed a commit that referenced this pull request Jul 18, 2019
asfgit pushed a commit that referenced this pull request Jul 19, 2019
asfgit pushed a commit that referenced this pull request Jul 21, 2019
asfgit pushed a commit that referenced this pull request Jul 22, 2019
asfgit pushed a commit that referenced this pull request Jul 23, 2019
asfgit pushed a commit that referenced this pull request Jul 25, 2019
asfgit pushed a commit that referenced this pull request Jul 28, 2019
asfgit pushed a commit that referenced this pull request Jul 30, 2019
asfgit pushed a commit that referenced this pull request Aug 1, 2019
asfgit pushed a commit that referenced this pull request Aug 2, 2019
asfgit pushed a commit that referenced this pull request Aug 7, 2019
asfgit pushed a commit that referenced this pull request Aug 8, 2019
asfgit pushed a commit that referenced this pull request Aug 15, 2019
asfgit pushed a commit that referenced this pull request Aug 16, 2019
asfgit pushed a commit that referenced this pull request Aug 18, 2019
asfgit pushed a commit that referenced this pull request Aug 22, 2019
asfgit pushed a commit that referenced this pull request Sep 11, 2019
asfgit pushed a commit that referenced this pull request Sep 16, 2019
asfgit pushed a commit that referenced this pull request Sep 17, 2019
asfgit pushed a commit that referenced this pull request Sep 18, 2019
asfgit pushed a commit that referenced this pull request Sep 20, 2019
asfgit pushed a commit that referenced this pull request Sep 24, 2019
asfgit pushed a commit that referenced this pull request Oct 5, 2019
asfgit pushed a commit that referenced this pull request Oct 28, 2019
asfgit pushed a commit that referenced this pull request Nov 5, 2019
asfgit pushed a commit that referenced this pull request Nov 10, 2019
asfgit pushed a commit that referenced this pull request Nov 13, 2019
asfgit pushed a commit that referenced this pull request Dec 24, 2019
asfgit pushed a commit that referenced this pull request Feb 2, 2020
asfgit pushed a commit that referenced this pull request Feb 3, 2020
asfgit pushed a commit that referenced this pull request Feb 4, 2020
asfgit pushed a commit that referenced this pull request Feb 6, 2020
asfgit pushed a commit that referenced this pull request Feb 7, 2020
asfgit pushed a commit that referenced this pull request Feb 8, 2020
asfgit pushed a commit that referenced this pull request Feb 9, 2020
asfgit pushed a commit that referenced this pull request Feb 12, 2020
asfgit pushed a commit that referenced this pull request Feb 20, 2020
asfgit pushed a commit that referenced this pull request Feb 22, 2020
asfgit pushed a commit that referenced this pull request Feb 25, 2020
asfgit pushed a commit that referenced this pull request Feb 26, 2020
asfgit pushed a commit that referenced this pull request Feb 29, 2020
Apache9 added a commit that referenced this pull request Mar 2, 2020
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
…aded (apache#362)

Signed-off-by: Guanghao Zhang <[email protected]>

(cherry picked from commit d364364)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants