-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-22664 Move protobuf stuff in hbase-rsgroup to hbase-protocol-sh… #362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSGroupAdminEndpoint should import shaded proto?
public static HBaseProtos.TimeRange toTimeRange(TimeRange timeRange) { | ||
if (timeRange == null) { | ||
timeRange = TimeRange.allTime(); | ||
public static RSGroupProtos.RSGroupInfo toProtoGroupInfo(RSGroupInfo pojo) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method should be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least we still need it for now as it is referenced in lots of places. Not sure if we can remove it at the end. FWIW, I think we still need to support the old way to change rsgroup, which uses coprocessor endpoint?
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Any other concerns? @infraio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. The RSGroupAdmin.proto not be removed and just copied to shade protobuf module.
+1.
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (apache#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (apache#362) Signed-off-by: Guanghao Zhang <[email protected]>
…aded (apache#362) Signed-off-by: Guanghao Zhang <[email protected]> (cherry picked from commit d364364)
…aded