-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-25709 Close region may stuck when region is compacting and skip… #3117
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Question up on the JIRA... asking if this config should just be on always.... rather than default off.
One comment in the below.
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScannerContext.java
Outdated
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@sunhelly Looks like there is still a compile issue with the new test case? |
27a9510
to
3dae794
Compare
Thank for reviewing, @apurtell , the compile issue is about the name change of class HBaseTestingUtility. The PR is updated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
No compile issues now, thanks for reviewing, @apurtell. |
…ped most cells read (#3117) Signed-off-by: Andrew Purtell <[email protected]>
…ped most cells read (#3117) Signed-off-by: Andrew Purtell <[email protected]>
…ped most cells read (#3117) Signed-off-by: Andrew Purtell <[email protected]>
…ompacting and skipped most cells read (apache#3117) Signed-off-by: Andrew Purtell <[email protected]>
…ompacting and skipped most cells read (apache#3117) Signed-off-by: Andrew Purtell <[email protected]>
…and skipped most cells read (apache#3117)" This reverts commit f3a48d1.
…and skipped most cells read (#3117)" (#4524) This reverts commit f3a48d1. Signed-off-by: Andrew Purtell <[email protected]>
…and skipped most cells read (#3117)" (#4524) This reverts commit f3a48d1. Signed-off-by: Andrew Purtell <[email protected]> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
…and skipped most cells read (#3117)" (#4524) This reverts commit f3a48d1. Signed-off-by: Andrew Purtell <[email protected]> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
…and skipped most cells read (#3117)" (#4524) This reverts commit f3a48d1. Signed-off-by: Andrew Purtell <[email protected]> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
…ion is compacting and skipped most cells read (apache#3117)" This reverts commit 35ec27d.
…and skipped most cells read (apache#3117)" (apache#4524) This reverts commit f3a48d1. Signed-off-by: Andrew Purtell <[email protected]>
…pacting and skipped most cells read (apache#3117)" (apache#4524)" This reverts commit f718c8a.
…ped most cells read (apache#3117) Signed-off-by: Andrew Purtell <[email protected]> (cherry picked from commit 45801a7) Change-Id: Icf9795caab949c2269ee7500533826ebbe67c3d0
…and skipped most cells read (apache#3117)" (apache#4524) This reverts commit f3a48d1. Signed-off-by: Andrew Purtell <[email protected]> Change-Id: I80028eea530a97f9d6d7e447b1e05d8b5a159cad
…ped most cells read