HBASE-25709 Close region may stuck when region is compacting and skip…

…ped most cells read
apache · Apr 9, 2021 · c0f4601 · c0f4601
1 parent 446f22f
commit c0f4601
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
@@ -751,6 +751,12 @@ public boolean next(List<Cell> outResult, ScannerContext scannerContext) throws
           default:
             throw new RuntimeException("UNEXPECTED");
         }
+        // when reaching the heartbeat check, try to return from the loop,
+        // to avoid the cycle of skipped cells. See HBASE-25709
+        if (kvsScanned % cellsPerHeartbeatCheck == 0) {
+          return scannerContext.setScannerState(NextState.MORE_VALUES).hasMoreValues();
+        }
+
       } while ((cell = this.heap.peek()) != null);
 
       if (count > 0) {

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
@@ -401,8 +401,9 @@ protected boolean performCompaction(FileDetails fd, InternalScanner scanner, Cel
     String compactionName = ThroughputControlUtil.getNameForThrottling(store, "compaction");
     long now = 0;
     boolean hasMore;
-    ScannerContext scannerContext =
-          ScannerContext.newBuilder().setBatchLimit(compactionKVMax).build();
+    ScannerContext scannerContext = ScannerContext.newBuilder()
+      .setBatchLimit(compactionKVMax)
+      .build();
 
     throughputController.start(compactionName);
     KeyValueScanner kvs = (scanner instanceof KeyValueScanner) ? (KeyValueScanner) scanner : null;