-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-25542 Add client detail to scan name so when lease expires, we … #2930
Conversation
Hard to add test. Lease requires RSRpcService context. |
🎊 +1 overall
This message was automatically generated. |
…have clue on who was scanning When we create a scanner lease, record client ip and port (removed unnecessary store of scannerName).
bc2c9e9
to
53464ff
Compare
Added a simple test because I don't see the new output after running all unit tests under hbase-server. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Thank you for adding this info for trouble shooting lease expiration. I have two concerns here that might need to be addressed:
|
LGTM |
#2930) * HBASE-25542 Add client detail to scan name so when lease expires, we have clue on who was scanning When we create a scanner lease, record client ip and port (removed unnecessary store of scannerName). Signed-off-by: Clara Xiong <[email protected]>
#2930) * HBASE-25542 Add client detail to scan name so when lease expires, we have clue on who was scanning When we create a scanner lease, record client ip and port (removed unnecessary store of scannerName). Signed-off-by: Clara Xiong <[email protected]>
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
apache#2930) * HBASE-25542 Add client detail to scan name so when lease expires, we have clue on who was scanning When we create a scanner lease, record client ip and port (removed unnecessary store of scannerName). Signed-off-by: Clara Xiong <[email protected]>
apache#2930) * HBASE-25542 Add client detail to scan name so when lease expires, we have clue on who was scanning When we create a scanner lease, record client ip and port (removed unnecessary store of scannerName). Signed-off-by: Clara Xiong <[email protected]>
…have clue on who was scanning
When we create a scanner lease, record client ip and port (removed
unnecessary store of scannerName).