fix bug: string out of bounds when construct illegal tablename error …

…message (#2884) Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: stack <[email protected]>
apache · Feb 8, 2021 · 9b6c135 · 9b6c135
1 parent 2a4e038
commit 9b6c135
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java
@@ -185,16 +185,14 @@ public static void isLegalTableQualifierName(final byte[] qualifierName,
     if(end - start < 1) {
       throw new IllegalArgumentException(isSnapshot ? "Snapshot" : "Table" + " qualifier must not be empty");
     }
+    String qualifierString = Bytes.toString(qualifierName, start, end - start);
     if (qualifierName[start] == '.' || qualifierName[start] == '-') {
       throw new IllegalArgumentException("Illegal first character <" + qualifierName[start] +
                                          "> at 0. " + (isSnapshot ? "Snapshot" : "User-space table") +
                                          " qualifiers can only start with 'alphanumeric " +
                                          "characters' from any language: " +
-                                         Bytes.toString(qualifierName, start, end));
+                                         qualifierString);
     }
-    // Treat the bytes as UTF-8
-    String qualifierString = new String(
-        qualifierName, start, (end - start), StandardCharsets.UTF_8);
     if (qualifierString.equals(DISALLOWED_TABLE_NAME)) {
       // Per https://zookeeper.apache.org/doc/r3.4.10/zookeeperProgrammers.html#ch_zkDataModel
       // A znode named "zookeeper" is disallowed by zookeeper.

diff --git a/hbase-common/src/test/java/org/apache/hadoop/hbase/TestTableName.java b/hbase-common/src/test/java/org/apache/hadoop/hbase/TestTableName.java
@@ -137,7 +137,7 @@ public int hashCode() {
 
   @Test public void testIllegalHTableNames() {
     for (String tn : illegalTableNames) {
-      assertThrows(Exception.class,
+      assertThrows(IllegalArgumentException.class,
         () -> TableName.isLegalFullyQualifiedTableName(Bytes.toBytes(tn)));
     }
   }