[#5109] fix(doc): fix link to documentation website in README #5149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunpingDu
reviewed
Oct 16, 2024
There was a problem hiding this comment.
we should use “https://gravitino.apache.org/docs/{version}” instead, as gravitino project is apache project now and apache website is the official document site.
For version, I would suggest to use "latest" which will link to the latest version (now is 0.6.0-incubating) automatically. Otherwise, it need to be updated once we have new version.
Beside doc folder here, we have several other links in README.md, such as how to build, how to test, .... Can you help to update them together?
|
@JunpingDu please let me know if I missed anything |
jerryshao
changed the title
jerryshao
changed the title
jerryshao
approved these changes
Oct 22, 2024
mplmoknijb
pushed a commit
to mplmoknijb/gravitino
that referenced
this pull request
Nov 6, 2024
…pache#5149) ### What changes were proposed in this pull request? - Link to documentation website ### Why are the changes needed? - Link to documentation website instead of documentation directory for easier access Fix: apache#5109 ### Does this PR introduce _any_ user-facing change? - No user-facing changes ### How was this patch tested? - Link to website shows in README upon updating text --------- Co-authored-by: Jerry Shao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #5109
Does this PR introduce any user-facing change?
How was this patch tested?