Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] README.md should refer the link to our doc website but not doc's source directory #5109

Closed
JunpingDu opened this issue Oct 11, 2024 · 5 comments · Fixed by #5149
Assignees
Labels
0.7.0 Release v0.7.0 good first issue Good for newcomers help wanted Extra attention is needed improvement Improvements on everything

Comments

@JunpingDu
Copy link
Contributor

What would you like to be improved?

README.md is the front page for an open source project, and most users try to locate the related documents they need.
Usually it should link to a document website (if project has), such as spark, ray, etc. which is more convenient for users to read - comparing with our source doc in markdown format.

How should we improve?

Replace the link that point to doc source with link to doc site (latest version).

@JunpingDu JunpingDu added the improvement Improvements on everything label Oct 11, 2024
@jerryshao jerryshao added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 12, 2024
@SeanAverS
Copy link
Contributor

Hi,

I'm interested on working on this. Could I please be assigned? Thanks.

@yuqi1129
Copy link
Contributor

Hi,

I'm interested on working on this. Could I please be assigned? Thanks.

Sure,please go ahead.

@JunpingDu
Copy link
Contributor Author

@SeanAverS welcome to your contributions, I just assign the issue to you, please go ahead to work on it!

@JunpingDu
Copy link
Contributor Author

Thanks for the patch, @SeanAverS ! I have some review comments in your PR, would you take a look? thx!

jerryshao added a commit that referenced this issue Oct 22, 2024
### What changes were proposed in this pull request?

- Link to documentation website 

### Why are the changes needed?

- Link to documentation website instead of documentation directory for
easier access

Fix: #5109 

### Does this PR introduce _any_ user-facing change?

- No user-facing changes 

### How was this patch tested?

- Link to website shows in README upon updating text

---------

Co-authored-by: Jerry Shao <[email protected]>
@jerryshao jerryshao added the 0.7.0 Release v0.7.0 label Oct 22, 2024
@JunpingDu
Copy link
Contributor Author

Thanks for your contribution, @SeanAverS .
Also, Congratulations on the first gravitino patch! :)

mplmoknijb pushed a commit to mplmoknijb/gravitino that referenced this issue Nov 6, 2024
…pache#5149)

### What changes were proposed in this pull request?

- Link to documentation website 

### Why are the changes needed?

- Link to documentation website instead of documentation directory for
easier access

Fix: apache#5109 

### Does this PR introduce _any_ user-facing change?

- No user-facing changes 

### How was this patch tested?

- Link to website shows in README upon updating text

---------

Co-authored-by: Jerry Shao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.7.0 Release v0.7.0 good first issue Good for newcomers help wanted Extra attention is needed improvement Improvements on everything
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants