[#5094] Fix(catalog-lakehouse-paimon): make some table properties from reserved to immutable #5095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caican00
force-pushed
the
fix-paimon-catalog-props
branch
from
07bda56 to
32b9ae5
Compare
|
Hi @FANNG1 could you help review this pr? Thanks |
caican00
force-pushed
the
fix-paimon-catalog-props
branch
from
27005cf to
92d147b
Compare
FANNG1
reviewed
Oct 11, 2024
|
Overal LGTM |
@FANNG1 please review again, thanks! |
FANNG1
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
make some table properties from reserved to immutable.
Why are the changes needed?
these table properties are immutable in Paimon.
Fix: #5094
Does this PR introduce any user-facing change?
updated related doc.
How was this patch tested?
modified UT.