Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][catalog-lakehouse-paimon] make some table properties from reserved to immutable #5094

Closed
caican00 opened this issue Oct 10, 2024 · 6 comments · Fixed by #5095
Closed

[Improvement][catalog-lakehouse-paimon] make some table properties from reserved to immutable #5094

caican00 opened this issue Oct 10, 2024 · 6 comments · Fixed by #5095
Assignees
@caican00
Labels
0.7.0 Release v0.7.0 bug Something isn't working improvement Improvements on everything

Comments

@caican00
Copy link
Collaborator

What would you like to be improved?

make some table properties from reserved to immutable.

bucket-key
merge-engine
sequence.field
rowkind.field
primary-key
partition

How should we improve?

No response
@caican00 caican00 added the improvement Improvements on everything label Oct 10, 2024
@caican00 caican00 self-assigned this Oct 10, 2024
@caican00 caican00 added the bug Something isn't working label Oct 10, 2024
@caican00 caican00 mentioned this issue Oct 10, 2024
Merged
@mchades
Copy link
Contributor

mchades commented Oct 11, 2024

For which catalog?

@FANNG1
Copy link
Contributor

FANNG1 commented Oct 11, 2024

why remove the properties from reserved? such as primary-key and bucket-key should be set using index and distribution interfaces not by using properties.

@FANNG1
Copy link
Contributor

FANNG1 commented Oct 11, 2024

IMO, we could make merge-engine , sequence.field, rowkind.field to immutable, @caican00 WDYT?

@caican00
Copy link
Collaborator Author

For which catalog?

paimon

@caican00
Copy link
Collaborator Author

IMO, we could make merge-engine , sequence.field, rowkind.field to immutable, @caican00 WDYT?

yes, it is resonable. i will update the related pr.

@caican00 caican00 changed the title [Improvement] make some table properties from reserved to immutable [Improvement][catalog-lakehouse-paimon] make some table properties from reserved to immutable Oct 11, 2024
@caican00
Copy link
Collaborator Author

caican00 commented Oct 11, 2024 •
edited
Loading

IMO, we could make merge-engine , sequence.field, rowkind.field to immutable, @caican00 WDYT?

yes, it is resonable. i will update the related pr.

@FANNG1 please review again, thank you

@FANNG1 FANNG1 closed this as completed in 8de31cd Oct 12, 2024
@FANNG1 FANNG1 added the 0.7.0 Release v0.7.0 label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caican00 caican00

Labels
0.7.0 Release v0.7.0 bug Something isn't working improvement Improvements on everything
Projects
None yet
Milestone
No milestone
3 participants
@FANNG1 @mchades @caican00