-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3758] Improvement(PyGVFS): Support OAuth2 authentication in Python GVFS #5030
Conversation
@jerqi would you please help to review this PR? |
Could you correct your typo about |
docs/how-to-use-gvfs.md
Outdated
@@ -538,7 +542,7 @@ print(documents) | |||
|
|||
### Authentication | |||
|
|||
Currently, Gravitino Virtual File System in Python only supports one kind of authentication types to access Gravitino server: `simple`. | |||
Currently, Gravitino Virtual File System in Python supports two kinds of authentication types to access Gravitino server: `simple` and `oatuh2`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oathu2
-> oauth2
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What changes were proposed in this pull request?
Support OAuth2 authentication in PyGVFS so that it can interact with the Gravitino server. This is supported in Java GVFS and we should also support it in PyGVFS. This is depended on #5026 which refactor the Python GVFS.
Why are the changes needed?
Fix: #3758
How was this patch tested?
Add some UTs.