Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3758] Improvement(PyGVFS): Support OAuth2 authentication in Python GVFS #5030

Merged
merged 9 commits into from
Oct 9, 2024

Conversation

xloya
Copy link
Contributor

@xloya xloya commented Sep 27, 2024

What changes were proposed in this pull request?

Support OAuth2 authentication in PyGVFS so that it can interact with the Gravitino server. This is supported in Java GVFS and we should also support it in PyGVFS. This is depended on #5026 which refactor the Python GVFS.

Why are the changes needed?

Fix: #3758

How was this patch tested?

Add some UTs.

@xloya xloya self-assigned this Sep 27, 2024
@jerryshao
Copy link
Contributor

@jerqi would you please help to review this PR?

@jerqi
Copy link
Contributor

jerqi commented Sep 29, 2024

Could you correct your typo about Oauth? It should be OAuth.

@xloya xloya changed the title [#3758] Improvement(PyGVFS): Support Oauth2 authentication in Python GVFS [#3758] Improvement(PyGVFS): Support OAuth2 authentication in Python GVFS Oct 8, 2024
@jerryshao jerryshao requested a review from jerqi October 9, 2024 02:11
@@ -538,7 +542,7 @@ print(documents)

### Authentication

Currently, Gravitino Virtual File System in Python only supports one kind of authentication types to access Gravitino server: `simple`.
Currently, Gravitino Virtual File System in Python supports two kinds of authentication types to access Gravitino server: `simple` and `oatuh2`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oathu2 -> oauth2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jerryshao jerryshao merged commit ce22323 into apache:main Oct 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Support OAuth2 auth in PyGVFS
3 participants