[#4280] improvement(PyGVFS): Refactor the getFileLocation logic in the Python GVFS
#5026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xloya
force-pushed
the
refactor-python-gvfs
branch
from
9d7d6d5 to
a9eaf6c
Compare
|
@jerryshao This PR is ready for review, please take a look when you have time, thanks. This is the last PR for unifying Fileset metadata operations and data operations audits into the server. The remaining data operation caller context reported to the external system for audit will be provided after the feature is completed at #4887. |
|
Gentle pin @jerryshao |
|
Sure, I will take a look at this today. |
jerryshao
reviewed
Oct 8, 2024
xloya
commented
Oct 8, 2024
| context.get_storage_type(), context.get_actual_path() | ||
| ), | ||
| if mode in ("w", "wb"): | ||
| data_operation = FilesetDataOperation.OPEN_AND_WRITE |
There was a problem hiding this comment.
@jerqi I'm adding two new operations: OPEN_AND_WRITE / OPEN_AND_APPEND, so it can be more clear to define the data operation here.
jerryshao
reviewed
Oct 8, 2024
common/src/main/java/org/apache/gravitino/audit/FilesetDataOperation.java
Show resolved
Hide resolved
jerryshao
pushed a commit
that referenced
this pull request
Oct 9, 2024
…GVFS (#5030) ### What changes were proposed in this pull request? Support OAuth2 authentication in PyGVFS so that it can interact with the Gravitino server. This is supported in Java GVFS and we should also support it in PyGVFS. This is depended on #5026 which refactor the Python GVFS. ### Why are the changes needed? Fix: #3758 ### How was this patch tested? Add some UTs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor the logic of getting the file location in Python GVFS.
Why are the changes needed?
Fix: #4280
How was this patch tested?
Refactor the UTs and reserved ITs works well.