[#4580] feat(catalog): unify cloud storage configurations #4897
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.gravitino.storage; | ||
|
|
||
| // Defines the unified OSS properties for different catalogs and connectors. | ||
| public class OSSProperties { | ||
|
|
||
| // The endpoint of Aliyun OSS service. | ||
| public static final String GRAVITINO_OSS_ENDPOINT = "oss-endpoint"; | ||
| // The static access key ID used to access OSS data. | ||
| public static final String GRAVITINO_OSS_ACCESS_KEY_ID = "oss-access-key-id"; | ||
| // The static access key secret used to access OSS data. | ||
| public static final String GRAVITINO_OSS_ACCESS_KEY_SECRET = "oss-access-key-secret"; | ||
|
|
||
|
There was a problem hiding this comment. The There was a problem hiding this comment. updated the docs to use access key secret for OSS |
||
| private OSSProperties() {} | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.gravitino.storage; | ||
|
|
||
| // Defines the unified S3 properties for different catalogs and connectors. | ||
| public class S3Properties { | ||
| // An alternative endpoint of the S3 service, This could be used to for S3FileIO with any | ||
| // s3-compatible object storage service that has a different endpoint, or access a private S3 | ||
| // endpoint in a virtual private cloud | ||
| public static final String GRAVITINO_S3_ENDPOINT = "s3-endpoint"; | ||
| // The static access key ID used to access S3 data. | ||
| public static final String GRAVITINO_S3_ACCESS_KEY_ID = "s3-access-key-id"; | ||
| // The static secret access key used to access S3 data. | ||
| public static final String GRAVITINO_S3_SECRET_ACCESS_KEY = "s3-secret-access-key"; | ||
| // The region of the S3 service. | ||
| public static final String GRAVITINO_S3_REGION = "s3-region"; | ||
|
|
||
| private S3Properties() {} | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have the GCS related configurations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, because GCS need to create credential according to a credential file, For Iceberg, it could only load credential file by setting ENV vars explicitly or load from GCS instance implicitly.