[#4580] feat(catalog): unify cloud storage configurations #4897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diqiu50
reviewed
Sep 10, 2024
There seems no need to update the document, this is internal, the other catalog like fileset or engine could reuse the storage properties. |
FANNG1
changed the title
diqiu50
reviewed
Sep 12, 2024
| public static final String GRAVITINO_OSS_ACCESS_KEY_ID = "oss-access-key-id"; | ||
| // The static secret access key used to access OSS data. | ||
| public static final String GRAVITINO_OSS_ACCESS_KEY_SECRET = "oss-access-key-secret"; | ||
|
|
There was a problem hiding this comment.
The oss-access-key-secret is mismatch with the docs. is it right?
There was a problem hiding this comment.
updated the docs to use access key secret for OSS
jerryshao
reviewed
Sep 12, 2024
| public static final String ICEBERG_OSS_ACCESS_KEY_ID = "client.access-key-id"; | ||
| public static final String GRAVITINO_OSS_ACCESS_KEY_SECRET = "oss-access-key-secret"; | ||
| public static final String ICEBERG_OSS_ACCESS_KEY_SECRET = "client.access-key-secret"; |
There was a problem hiding this comment.
Do we have the GCS related configurations?
There was a problem hiding this comment.
no, because GCS need to create credential according to a credential file, For Iceberg, it could only load credential file by setting ENV vars explicitly or load from GCS instance implicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
unify the storage configurations
Why are the changes needed?
Fix: #4580
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests