Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4735] improvement(core): Optimize the thrown duplicated entry error message #4838

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

xloya
Copy link
Contributor

@xloya xloya commented Sep 2, 2024

What changes were proposed in this pull request?

Optimize the exception message of SQLException thrown in UI when duplicate entities occurs.
image

Why are the changes needed?

Fix: #4735

How was this patch tested?

Add some UTs.

@xloya
Copy link
Contributor Author

xloya commented Sep 2, 2024

cc @jerqi.

@mchades mchades requested a review from jerqi September 2, 2024 13:10
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuqi1129 yuqi1129 merged commit 3dd59a8 into apache:main Sep 2, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Rename a metalake to an existing metalake
3 participants