Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Rename a metalake to an existing metalake #4735

Closed
jerqi opened this issue Aug 28, 2024 · 1 comment · Fixed by #4838
Closed

[Improvement] Rename a metalake to an existing metalake #4735

jerqi opened this issue Aug 28, 2024 · 1 comment · Fixed by #4838
Assignees
@xloya
Labels
good first issue Good for newcomers help wanted Extra attention is needed improvement Improvements on everything

Comments

@jerqi
Copy link
Contributor

jerqi commented Aug 28, 2024

What would you like to be improved?

16611724845436_ pic

How should we improve?

We shouldn't throw SQL exception to front end. We should wrap to MetalakeAlreadyExistException.
@jerqi jerqi added improvement Improvements on everything good first issue Good for newcomers help wanted Extra attention is needed labels Aug 28, 2024
@xloya
Copy link
Contributor

xloya commented Sep 2, 2024

Actually the duplicated key SQLException has been converted to EntityAlreadyExistsException, so I think it's best to optimize the exception information thrown here. I will check and change the exception information thrown here.

@xloya xloya self-assigned this Sep 2, 2024
@xloya xloya mentioned this issue Sep 2, 2024
Merged
yuqi1129 pushed a commit that referenced this issue Sep 2, 2024
@xloya
[#4735] improvement(core): Optimize the thrown duplicated entry error…
3dd59a8 
… message (#4838)

### What changes were proposed in this pull request?

Optimize the exception message of `SQLException` thrown in UI when
duplicate entities occurs.

![image](https://github.com/user-attachments/assets/df74c64e-097a-4845-9ec7-cf914934b26d)

### Why are the changes needed?

Fix: #4735 

### How was this patch tested?

Add some UTs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xloya xloya

Labels
good first issue Good for newcomers help wanted Extra attention is needed improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#4735] improvement(core): Optimize the thrown duplicated entry error message xloya/gravitino
2 participants
@jerqi @xloya