[#4209] Improvement(server-common): Update charset handling to use StandardCharsets.UTF_8 #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devesh-2002 |
|
@yuqi1129, Thank you for the suggestion. I have run the formatting command. Still, please let me know, if any changes are needed. |
jerryshao
reviewed
Jul 24, 2024
| // } | ||
| // PrincipalName ::= SEQUENCE { | ||
| // name-string[1] SEQUENCE OF String | ||
| // name-string[1] SEQUENCE OF String |
There was a problem hiding this comment.
I think the changes here and above are not necessary, it would be better not to change them.
jerryshao
changed the title
jerryshao
changed the title
|
@devesh-2002 there's some build issues, can you please fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replaced Hardcoded "UTF-8" with
StandardCharsets.UTF-8in KerberosServerUtils.javaWhy are the changes needed?
The changes were needed to ensure adherence to best code practices, specifically by replacing hardcoded charset strings with the use of
StandardCharsets.UTF_8, promoting clarity, consistency, and robustness in charset handling.Fix: #4209,
Does this PR introduce any user-facing change?
No
Please let me know, if any further changes are needed.