Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] In KerberosServerUtils.java replace hardcoded string #4209

Open
justinmclean opened this issue Jul 19, 2024 · 10 comments · May be fixed by #4344
Open

[Improvement] In KerberosServerUtils.java replace hardcoded string #4209

justinmclean opened this issue Jul 19, 2024 · 10 comments · May be fixed by #4344
Assignees
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

Replace hardcoded string

How should we improve?

Replace "UTF-8" with StandardCharsets.UTF_8

@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Jul 19, 2024
@devesh-2002
Copy link

May i take this issue?

@yuqi1129
Copy link
Contributor

@devesh-2002
Sure, please go ahead.

@justinmclean
Copy link
Member Author

Looks like this may have been a false positive as the current changes gives this error:

/home/runner/work/gravitino/gravitino/server-common/src/main/java/org/apache/gravitino/server/authentication/KerberosServerUtils.java:361: error: incompatible types: Charset cannot be converted to String
> Task :catalogs:catalog-jdbc-postgresql:copyCatalogLibs
        throw new IllegalCharsetNameException(StandardCharsets.UTF_8); // won't happen.

@zzzk1
Copy link

zzzk1 commented Jul 30, 2024

@devesh-2002 are you still work on this?
@yuqi1129 If possible I would like to be able to start.

@yuqi1129
Copy link
Contributor

@zzzk1
If you have free time, please go ahead. Perhaps @devesh-2002 is occupied with some issues.

@devesh-2002
Copy link

I am very sorry I couldn't look into it due to some issues. I will try to look into it asap.

@justinmclean
Copy link
Member Author

It's best to make sure your code can compile before making a pull request.

@devesh-2002
Copy link

I am really sorry for taking so much time. Due to some reasons, I won't be able to work upon this issue further.

@zzzk1, please work upon this issue, if you are interested.

@justinmclean
Copy link
Member Author

@zzk1 feel free to work on this @devesh-2002 thanks for your time in looking into this this

@FANNG1
Copy link
Contributor

FANNG1 commented Aug 5, 2024

@zzzk1 , are you still working on this issue? @mrkartik00 had proposed #4344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
5 participants