[#3320] fix(client): shadow slf4j for client-java-runtime #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
changed the title
|
@FANNG1 |
FANNG1
changed the title
created corresponding issues, please check it again. |
jerryshao
reviewed
May 10, 2024
| @@ -29,6 +29,7 @@ tasks.withType<ShadowJar>(ShadowJar::class.java) { | |||
| relocate("com.google", "com.datastrato.gravitino.shaded.com.google") | |||
| relocate("google", "com.datastrato.gravitino.shaded.google") | |||
| relocate("org.apache.hc", "com.datastrato.gravitino.shaded.org.apache.hc") | |||
| relocate("org.apache.logging.slf4j", "com.datastrato.gravitino.shaded.org.apache.logging.slf4j") | |||
There was a problem hiding this comment.
Since you already relocate the slf4j jar in client-java-runtime, do you need to relocate again in here?
There was a problem hiding this comment.
I checked by extracting the jar package, it doesn't exist, thanks for pointing this.
jerryshao
approved these changes
May 10, 2024
FANNG1
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
May 10, 2024
### What changes were proposed in this pull request? shadow slf4j for client-java-runtime and spark-connector-runtime ### Why are the changes needed? some systems like spark 3.3 need low version log4j, will encounter the conflict bug: ``` java.lang.NoSuchMethodError: org.apache.logging.slf4j.Log4jLoggerFactory: method 'void <init>()' not found ``` fix: #3320 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…he#3318) ### What changes were proposed in this pull request? shadow slf4j for client-java-runtime and spark-connector-runtime ### Why are the changes needed? some systems like spark 3.3 need low version log4j, will encounter the conflict bug: ``` java.lang.NoSuchMethodError: org.apache.logging.slf4j.Log4jLoggerFactory: method 'void <init>()' not found ``` fix: apache#3320 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
shadow slf4j for client-java-runtime and spark-connector-runtime
Why are the changes needed?
some systems like spark 3.3 need low version log4j, will encounter the conflict bug:
fix: #3320
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests