[#3165] fix(client-java): Fix the http client toJson encode without UTF-8
#3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerryshao Could you please take a look of this? Thanks. |
xloya
changed the title
toJson encode without UTF-8
jerryshao
reviewed
Apr 30, 2024
| "这是中文comment", | ||
| Fileset.Type.MANAGED, | ||
| storageLocation, | ||
| ImmutableMap.of("k1", "v1")); |
There was a problem hiding this comment.
I think it is not just a comment that is affected by this issue, but also like storageLocation, property key and value, right? Can you also add tests to cover this?
There was a problem hiding this comment.
Add some assertions for this.
jerryshao
added
need backport
github-actions bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
… UTF-8 (#3179) ### What changes were proposed in this pull request? Currently in the java client, the json result is not encoded with `UTF-8` when requesting the server, which will cause some Chinese characters to be garbled.It will use `ISO_8859_1` as default. This PR fixed this.  ### Why are the changes needed? Fix: #3165 ### How was this patch tested? Add some ITs. --------- Co-authored-by: xiaojiebao <[email protected]>
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…ithout UTF-8 (apache#3179) ### What changes were proposed in this pull request? Currently in the java client, the json result is not encoded with `UTF-8` when requesting the server, which will cause some Chinese characters to be garbled.It will use `ISO_8859_1` as default. This PR fixed this.  ### Why are the changes needed? Fix: apache#3165 ### How was this patch tested? Add some ITs. --------- Co-authored-by: xiaojiebao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently in the java client, the json result is not encoded with
UTF-8when requesting the server, which will cause some Chinese characters to be garbled.It will useISO_8859_1as default. This PR fixed this.Why are the changes needed?
Fix: #3165
How was this patch tested?
Add some ITs.