Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] fileset commet meet garbled data #3165

Closed
hanwxx opened this issue Apr 24, 2024 · 4 comments · Fixed by #3179
Closed

[Bug report] fileset commet meet garbled data #3165

hanwxx opened this issue Apr 24, 2024 · 4 comments · Fixed by #3179
Assignees
@xloya
Labels
bug Something isn't working
Milestone
Gravitino June Re...

Comments

@hanwxx
Copy link
Contributor

hanwxx commented Apr 24, 2024

Version

main branch

Describe what's wrong

Create or update fileset comment，when inputting Chinese, the data taken out is garbled.
example:
input: 这是fileset中文描述
output: ??fileset????

Error message and/or stacktrace

no

How to reproduce

create fileset:
image

get fileset:
image

data in mysql:
image

Additional context

No response
@hanwxx hanwxx added the bug Something isn't working label Apr 24, 2024
@jerryshao
Copy link
Contributor

@hanwxx can you please help to fix this issue?

@xloya
Copy link
Contributor

xloya commented Apr 24, 2024

I tracked some logs, and it seems that when it was requesting the server, garbled code had appeared.
image
image

@jerryshao
Copy link
Contributor

So seems like some string codec issue happens between client and server.

@jerryshao jerryshao added this to the Gravitino June Release milestone Apr 24, 2024
@xloya
Copy link
Contributor

xloya commented Apr 24, 2024

I have found the source problem, will open a PR to fix this later.

@xloya xloya mentioned this issue Apr 24, 2024
Merged
jerryshao pushed a commit that referenced this issue Apr 30, 2024
@xloya
[#3165] fix(client-java): Fix the http client toJson encode without…
d6fe135 
… UTF-8 (#3179)

### What changes were proposed in this pull request?

Currently in the java client, the json result is not encoded with
`UTF-8` when requesting the server, which will cause some Chinese
characters to be garbled.It will use `ISO_8859_1` as default. This PR
fixed this.

![image](https://github.com/datastrato/gravitino/assets/26177232/9342dd32-1ded-4670-a3c7-37d9a5673955)

### Why are the changes needed?

Fix: #3165 

### How was this patch tested?

Add some ITs.

---------

Co-authored-by: xiaojiebao <[email protected]>
github-actions bot pushed a commit that referenced this issue Apr 30, 2024
@xloya @web-flow
[#3165] fix(client-java): Fix the http client toJson encode without…
d195496 
… UTF-8 (#3179)

### What changes were proposed in this pull request?

Currently in the java client, the json result is not encoded with
`UTF-8` when requesting the server, which will cause some Chinese
characters to be garbled.It will use `ISO_8859_1` as default. This PR
fixed this.

![image](https://github.com/datastrato/gravitino/assets/26177232/9342dd32-1ded-4670-a3c7-37d9a5673955)

### Why are the changes needed?

Fix: #3165 

### How was this patch tested?

Add some ITs.

---------

Co-authored-by: xiaojiebao <[email protected]>
@jerryshao jerryshao mentioned this issue Apr 30, 2024
Merged
jerryshao added a commit that referenced this issue Apr 30, 2024
@jerryshao @xloya
[#3165] fix(client-java): Fix the http client toJson encode without…
52e462c 
… UTF-8 (#3240)

### What changes were proposed in this pull request?

Currently in the java client, the json result is not encoded with
`UTF-8` when requesting the server, which will cause some Chinese
characters to be garbled.It will use `ISO_8859_1` as default. This PR
fixed this.

![image](https://github.com/datastrato/gravitino/assets/26177232/9342dd32-1ded-4670-a3c7-37d9a5673955)

### Why are the changes needed?

Fix: #3165 

### How was this patch tested?

Add some ITs.

Co-authored-by: xloya <[email protected]>
Co-authored-by: xiaojiebao <[email protected]>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@xloya @diqiu50
[apache#3165] fix(client-java): Fix the http client toJson encode w…
667d12e 
…ithout UTF-8 (apache#3179)

### What changes were proposed in this pull request?

Currently in the java client, the json result is not encoded with
`UTF-8` when requesting the server, which will cause some Chinese
characters to be garbled.It will use `ISO_8859_1` as default. This PR
fixed this.

![image](https://github.com/datastrato/gravitino/assets/26177232/9342dd32-1ded-4670-a3c7-37d9a5673955)

### Why are the changes needed?

Fix: apache#3165 

### How was this patch tested?

Add some ITs.

---------

Co-authored-by: xiaojiebao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xloya xloya

Labels
bug Something isn't working
Projects
None yet
Milestone
Gravitino June Release
Development

Successfully merging a pull request may close this issue.

[#3165] fix(client-java): Fix the http client toJson encode without UTF-8 xloya/gravitino
3 participants
@jerryshao @xloya @hanwxx