[#3081] improvement(core): Remove hack in BaseCatalog.java #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@noidname01 Thanks a lot for your contribution. I think the issue is misleading, this part of the code is required for the some advanced users, we just leave a back door for such users without documentation. |
|
@jerryshao Sure, so this issue is not necessary? |
|
I think what you need to do is to improve the comment to avoid saying that this is a hacky way. I think why @justinmclean created this issue is that he uses some tools to do code scan, that tool may trigger a warning when finding this keyword. |
|
OK, Got it |
jerryshao
added
need backport
jerryshao
approved these changes
Apr 24, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
### What changes were proposed in this pull request? Modify the description of `CATALOG_OPERATION_IMPL`, avoid the use of "hack" ### Why are the changes needed? Fix: #3081 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No need to test --------- Co-authored-by: TimWang <[email protected]>
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…che#3166) ### What changes were proposed in this pull request? Modify the description of `CATALOG_OPERATION_IMPL`, avoid the use of "hack" ### Why are the changes needed? Fix: apache#3081 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No need to test --------- Co-authored-by: TimWang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Modify the description of
CATALOG_OPERATION_IMPL, avoid the use of "hack"Why are the changes needed?
Fix: #3081
Does this PR introduce any user-facing change?
No
How was this patch tested?
No need to test