Skip to content

Commit

Permalink
[#3081] improvement(core): Remove hack in BaseCatalog.java (#3166)
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

Modify the description of `CATALOG_OPERATION_IMPL`, avoid the use of
"hack"

### Why are the changes needed?

Fix: #3081 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?
  
No need to test

---------

Co-authored-by: TimWang <[email protected]>
  • Loading branch information
noidname01 and TimWang authored Apr 24, 2024
1 parent b11c739 commit 79044b2
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,10 @@ public abstract class BaseCatalog<T extends BaseCatalog>
implements Catalog, CatalogProvider, HasPropertyMetadata {
private static final Logger LOG = LoggerFactory.getLogger(BaseCatalog.class);

// A hack way to inject custom operation to Gravitino, the object you used is not stable, don't
// use it unless you know what you are doing.
// This variable is used as a key in properties of catalogs to inject custom operation to
// Gravitino.
// You can use your own object to replace the default catalog operation.
// The object you used is not stable, don't use it unless you know what you are doing.
@VisibleForTesting public static final String CATALOG_OPERATION_IMPL = "ops-impl";

private CatalogEntity entity;
Expand Down

0 comments on commit 79044b2

Please sign in to comment.