[#2824] bugFix: Fixed abnormal timestamp type conversion between iceberg and gravitino #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tamp type conversion between iceberg and gravitino
|
Hi @FANNG1 could you help review this PR? Fixed an timestampType conversion exception. |
FANNG1
reviewed
Apr 7, 2024
.../test/java/com/datastrato/gravitino/catalog/lakehouse/iceberg/converter/TestConvertUtil.java
Show resolved
Hide resolved
FANNG1
reviewed
Apr 8, 2024
...va/com/datastrato/gravitino/catalog/lakehouse/iceberg/integration/test/CatalogIcebergIT.java
Show resolved
Hide resolved
FANNG1
approved these changes
Apr 8, 2024
|
@caican00 , thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
in com.datastrato.gravitino.catalog.lakehouse.iceberg.converter.ConvertUtil#formIcebergType
Why are the changes needed?
Fixed abnormal timestamp type conversion between iceberg and gravitino
Fix: #2824
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing Unit tests and new IT.