Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] abnormal timestamp type conversion between iceberg and gravitino #2824

Closed
caican00 opened this issue Apr 7, 2024 · 0 comments · Fixed by #2825
Closed

[Bug report] abnormal timestamp type conversion between iceberg and gravitino #2824

caican00 opened this issue Apr 7, 2024 · 0 comments · Fixed by #2825
Labels
bug Something isn't working

Comments

@caican00
Copy link
Collaborator

caican00 commented Apr 7, 2024 •
edited
Loading

Version

main branch

Describe what's wrong

loading a table from gravitino, we got an incorrect timestamp type when converting iceberg type to gravitino type. For example:

com.datastrato.gravitino.catalog.lakehouse.iceberg.converter.FromIcebergType#primitive

image

Error message and/or stacktrace

None

How to reproduce

None

Additional context

No response
@caican00 caican00 added the bug Something isn't working label Apr 7, 2024
caican00 added a commit to caican00/gravitino that referenced this issue Apr 7, 2024
@caican00
[apache#2824] bugfix(catalog-lakehouse-iceberg): Fixed abnormal times…
b64494e 
…tamp type conversion between iceberg and gravitino
@caican00 caican00 mentioned this issue Apr 7, 2024
Merged
FANNG1 pushed a commit that referenced this issue Apr 8, 2024
@caican00
[#2824] bugFix: Fixed abnormal timestamp type conversion between iceb…
ac28836 
…erg and gravitino (#2825)

### What changes were proposed in this pull request?

in
com.datastrato.gravitino.catalog.lakehouse.iceberg.converter.ConvertUtil#formIcebergType

```
Types.TimestampType.withZone() -> com.datastrato.gravitino.rel.types.Types.TimestampType.withTimeZone()

Types.TimestampType.withoutZone() -> com.datastrato.gravitino.rel.types.Types.TimestampType.withoutTimeZone()
```

### Why are the changes needed?

Fixed abnormal timestamp type conversion between iceberg and gravitino

Fix: #2824

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Existing Unit tests and new IT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@caican00