Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2518] feat(build): support Github CI for client-python #2684

Merged
merged 7 commits into from
Mar 27, 2024

Conversation

coolderli
Copy link
Contributor

What changes were proposed in this pull request?

  • use Gradle to manage Python build.
  • add Github CI
  • ./gradlew clean clients:client-python:test

Why are the changes needed?

Fix: #2518

Does this PR introduce any user-facing change?

  • no

How was this patch tested?

  • ./gradlew clean clients:client-python:test

@coolderli coolderli closed this Mar 26, 2024
@coolderli coolderli reopened this Mar 26, 2024
@coolderli coolderli closed this Mar 26, 2024
@coolderli coolderli reopened this Mar 26, 2024
@coolderli
Copy link
Contributor Author

@shaofengshi Could you please help view this? Thanks.

@shaofengshi
Copy link
Contributor

Cool, this PR not only add the Github CI, but also use Gradle to run the python local test!

One quick question, if a user only has Java development environment ready, not setup python environment, will the Gradle build fail? Will it automatically install python and pip when run the test? @coolderli

@coolderli
Copy link
Contributor Author

Cool, this PR not only add the Github CI, but also use Gradle to run the python local test!

One quick question, if a user only has Java development environment ready, not setup python environment, will the Gradle build fail? Will it automatically install python and pip when run the test? @coolderli

@shaofengshi It will install Pip but not Python. If the user has no Python environment, the build will fail. I don't think we need to install the Python for users. Users may not want to install it automatically. I take a look at the web module. I think it has the same issue if there is a lake of node.js in env. What do you think?

@shaofengshi
Copy link
Contributor

Cool, this PR not only add the Github CI, but also use Gradle to run the python local test!
One quick question, if a user only has Java development environment ready, not setup python environment, will the Gradle build fail? Will it automatically install python and pip when run the test? @coolderli

@shaofengshi It will install Pip but not Python. If the user has no Python environment, the build will fail. I don't think we need to install the Python for users. Users may not want to install it automatically. I take a look at the web module. I think it has the same issue if there is a lake of node.js in env. What do you think?

I'm just curious about that; It make sense, I agree with you. Thank you Peidian!

@jerryshao @qqqttt123 please review and merge the PR if no objection to this.

@jerryshao jerryshao changed the title feat(build): support Github CI for client-python [#2518] feat(build): support Github CI for client-python Mar 27, 2024
@jerryshao
Copy link
Contributor

Thanks @coolderli for your work, merging to main.

@jerryshao jerryshao merged commit 004fe89 into apache:main Mar 27, 2024
11 checks passed
shaofengshi added a commit that referenced this pull request Mar 28, 2024
yuqi1129 pushed a commit that referenced this pull request Mar 28, 2024
xunliu pushed a commit to xunliu/gravitino that referenced this pull request Mar 30, 2024
…e#2684)

### What changes were proposed in this pull request?

 - use Gradle to manage Python build.
 - add Github CI
 - `./gradlew clean clients:client-python:test`

### Why are the changes needed?

Fix: apache#2518 

### Does this PR introduce _any_ user-facing change?

- no

### How was this patch tested?

- `./gradlew clean clients:client-python:test`
xunliu pushed a commit to xunliu/gravitino that referenced this pull request Apr 1, 2024
…e#2684)

### What changes were proposed in this pull request?

 - use Gradle to manage Python build.
 - add Github CI
 - `./gradlew clean clients:client-python:test`

### Why are the changes needed?

Fix: apache#2518 

### Does this PR introduce _any_ user-facing change?

- no

### How was this patch tested?

- `./gradlew clean clients:client-python:test`
xunliu pushed a commit to xunliu/gravitino that referenced this pull request Apr 2, 2024
…e#2684)

### What changes were proposed in this pull request?

 - use Gradle to manage Python build.
 - add Github CI
 - `./gradlew clean clients:client-python:test`

### Why are the changes needed?

Fix: apache#2518 

### Does this PR introduce _any_ user-facing change?

- no

### How was this patch tested?

- `./gradlew clean clients:client-python:test`
xunliu pushed a commit to xunliu/gravitino that referenced this pull request Apr 3, 2024
…e#2684)

### What changes were proposed in this pull request?

 - use Gradle to manage Python build.
 - add Github CI
 - `./gradlew clean clients:client-python:test`

### Why are the changes needed?

Fix: apache#2518 

### Does this PR introduce _any_ user-facing change?

- no

### How was this patch tested?

- `./gradlew clean clients:client-python:test`
xunliu pushed a commit to xunliu/gravitino that referenced this pull request Apr 3, 2024
…e#2684)

### What changes were proposed in this pull request?

 - use Gradle to manage Python build.
 - add Github CI
 - `./gradlew clean clients:client-python:test`

### Why are the changes needed?

Fix: apache#2518 

### Does this PR introduce _any_ user-facing change?

- no

### How was this patch tested?

- `./gradlew clean clients:client-python:test`
xunliu pushed a commit to xunliu/gravitino that referenced this pull request Apr 3, 2024
…e#2684)

### What changes were proposed in this pull request?

 - use Gradle to manage Python build.
 - add Github CI
 - `./gradlew clean clients:client-python:test`

### Why are the changes needed?

Fix: apache#2518 

### Does this PR introduce _any_ user-facing change?

- no

### How was this patch tested?

- `./gradlew clean clients:client-python:test`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] integrate pytest with gradle to run python test with CICD
3 participants