-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2518] feat(build): support Github CI for client-python #2684
Conversation
@shaofengshi Could you please help view this? Thanks. |
Cool, this PR not only add the Github CI, but also use Gradle to run the python local test! One quick question, if a user only has Java development environment ready, not setup python environment, will the Gradle build fail? Will it automatically install python and pip when run the test? @coolderli |
@shaofengshi It will install Pip but not Python. If the user has no Python environment, the build will fail. I don't think we need to install the Python for users. Users may not want to install it automatically. I take a look at the |
I'm just curious about that; It make sense, I agree with you. Thank you Peidian! @jerryshao @qqqttt123 please review and merge the PR if no objection to this. |
Thanks @coolderli for your work, merging to main. |
…e#2684) ### What changes were proposed in this pull request? - use Gradle to manage Python build. - add Github CI - `./gradlew clean clients:client-python:test` ### Why are the changes needed? Fix: apache#2518 ### Does this PR introduce _any_ user-facing change? - no ### How was this patch tested? - `./gradlew clean clients:client-python:test`
…e#2684) ### What changes were proposed in this pull request? - use Gradle to manage Python build. - add Github CI - `./gradlew clean clients:client-python:test` ### Why are the changes needed? Fix: apache#2518 ### Does this PR introduce _any_ user-facing change? - no ### How was this patch tested? - `./gradlew clean clients:client-python:test`
…e#2684) ### What changes were proposed in this pull request? - use Gradle to manage Python build. - add Github CI - `./gradlew clean clients:client-python:test` ### Why are the changes needed? Fix: apache#2518 ### Does this PR introduce _any_ user-facing change? - no ### How was this patch tested? - `./gradlew clean clients:client-python:test`
…e#2684) ### What changes were proposed in this pull request? - use Gradle to manage Python build. - add Github CI - `./gradlew clean clients:client-python:test` ### Why are the changes needed? Fix: apache#2518 ### Does this PR introduce _any_ user-facing change? - no ### How was this patch tested? - `./gradlew clean clients:client-python:test`
…e#2684) ### What changes were proposed in this pull request? - use Gradle to manage Python build. - add Github CI - `./gradlew clean clients:client-python:test` ### Why are the changes needed? Fix: apache#2518 ### Does this PR introduce _any_ user-facing change? - no ### How was this patch tested? - `./gradlew clean clients:client-python:test`
…e#2684) ### What changes were proposed in this pull request? - use Gradle to manage Python build. - add Github CI - `./gradlew clean clients:client-python:test` ### Why are the changes needed? Fix: apache#2518 ### Does this PR introduce _any_ user-facing change? - no ### How was this patch tested? - `./gradlew clean clients:client-python:test`
What changes were proposed in this pull request?
./gradlew clean clients:client-python:test
Why are the changes needed?
Fix: #2518
Does this PR introduce any user-facing change?
How was this patch tested?
./gradlew clean clients:client-python:test