Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client-python): support Github CI for client-python #2573

Closed
wants to merge 8 commits into from

Conversation

coolderli
Copy link
Contributor

@coolderli coolderli commented Mar 18, 2024

What changes were proposed in this pull request?

  • add github ci to test python

Why are the changes needed?

Does this PR introduce any user-facing change?

  • no

How was this patch tested?

  • github pipeline

@coolderli coolderli marked this pull request as draft March 18, 2024 11:33
@coolderli coolderli closed this Mar 18, 2024
@coolderli coolderli reopened this Mar 18, 2024
@coolderli coolderli closed this Mar 18, 2024
@coolderli coolderli reopened this Mar 18, 2024
@coolderli coolderli closed this Mar 18, 2024
@coolderli coolderli reopened this Mar 18, 2024
@coolderli coolderli closed this Mar 18, 2024
@coolderli coolderli reopened this Mar 18, 2024
@coolderli coolderli marked this pull request as ready for review March 18, 2024 12:31
@coolderli coolderli changed the title feat(client-python): add github ci [SIP]feat(client-python): add github ci Mar 18, 2024
@coolderli coolderli closed this Mar 18, 2024
@coolderli coolderli reopened this Mar 18, 2024
@coolderli
Copy link
Contributor Author

@shaofengshi Hi, I use Github ci to have a test. Does this meet our needs?

@coolderli coolderli changed the title [SIP]feat(client-python): add github ci [SIP]feat(client-python): support Github CI for client-python Mar 18, 2024
@coolderli coolderli changed the title [SIP]feat(client-python): support Github CI for client-python feat(client-python): support Github CI for client-python Mar 19, 2024
@jerryshao
Copy link
Contributor

I think we'd better integrate with gradle, so one gradle command can run all the build/test things. The changes here only do the github CI, we still cannot run it locally.

@shaofengshi
Copy link
Contributor

Peidian, will this change make the github action longer? If the PR doesn't have change on Python, will the test python be triggred also? @coolderli

@coolderli
Copy link
Contributor Author

Peidian, will this change make the github action longer? If the PR doesn't have change on Python, will the test python be triggred also? @coolderli

@shaofengshi Yes, this will always be triggered for now. We can add some restrictions to it.

@coolderli
Copy link
Contributor Author

close this. because there is a new patch: #2684

@coolderli coolderli closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] integrate pytest with gradle to run python test with CICD
3 participants