[#2117] improvement(api): Type adds UNPARSED column data type to handle an unresolvable type from the catalog #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
force-pushed
the
GRAVITINO-2117
branch
from
665be5b to
42245d3
Compare
mchades
reviewed
Feb 9, 2024
api/src/main/java/com/datastrato/gravitino/rel/types/Types.java
Outdated
Show resolved
Hide resolved
SteNicholas
force-pushed
the
GRAVITINO-2117
branch
from
42245d3 to
00f6a00
Compare
SteNicholas
changed the title
SteNicholas
force-pushed
the
GRAVITINO-2117
branch
2 times, most recently
from
f98ca68 to
da04866
Compare
|
Could you please add related integration tests? |
SteNicholas
force-pushed
the
GRAVITINO-2117
branch
5 times, most recently
from
167bb0e to
007f184
Compare
SteNicholas
force-pushed
the
GRAVITINO-2117
branch
from
007f184 to
8000226
Compare
|
@mchades, I have added |
SteNicholas
force-pushed
the
GRAVITINO-2117
branch
from
8000226 to
e42ef7d
Compare
|
Overall LGTM, but missing support for Iceberg catalog, you need to modify |
…o handle an unresolvable type from the catalog
SteNicholas
force-pushed
the
GRAVITINO-2117
branch
from
e42ef7d to
d411243
Compare
|
@mchades, I have modified |
mchades
approved these changes
Feb 23, 2024
|
@SteNicholas |
|
The document related work will be tracked by #2323 |
mchades
pushed a commit
that referenced
this pull request
Feb 28, 2024
…solvable type from the catalog (#2337) ### What changes were proposed in this pull request? Document `UnparsedType` data type which handles an unresolvable type from the catalog. ### Why are the changes needed? `UnparsedType` data type that handles an unresolvable type from the catalog is supported in #2140. Fix: #2323 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TypeaddsUNPARSEDcolumn data type to handle an unresolvable type from the catalog.Why are the changes needed?
If a column data type in the catalog does not have a mapping in Gravitino, an exception will be thrown. We should map all data types from a catalog to Gravitino. However, in practical situations, loading exceptions may occur due to the addition of new data types or insufficient mapping support. Introduce
UnparsedTypeto represent the unparsed data type.Fix: #2117
Does this PR introduce any user-facing change?
TypeaddsUNKNOWNcolumn data type that represents an unresolvable type.How was this patch tested?
TestJsonUtils#testTypeSerDeTestTypes#testUnparsedTypeTestTypeConverter#testTypeConverterTestMysqlTypeConverter#testToGravitinoTypeTestPostgreSqlTypeConverter#testToGravitinoTypeCatalogMysqlIT#testUnparsedTypeConverterCatalogPostgreSqlIT#testUnparsedTypeConverter