[Improvement] Add Unknown column data type to handle an unresolvable type from the catalog
#2117
Comments
|
+1, loadTable is import for the newbies to try Gravitino |
|
@mchades, could you assign this ticket to me? Thanks. |
SteNicholas
added a commit
to SteNicholas/gravitino
that referenced
this issue
Feb 7, 2024
… handle an unresolvable type from the catalog
SteNicholas
added a commit
to SteNicholas/gravitino
that referenced
this issue
Feb 8, 2024
… handle an unresolvable type from the catalog
|
@jerryshao , what do you think to introducing |
|
If it is a unknown type, how would user know the actual type of the underlying sources? I would suggest to treat like a unparsed/unresolved type like what we do for unparsed expression, WDYT? |
|
@SteNicholas can we use a |
@FANNG1, I will update the pull request to use |
SteNicholas
added a commit
to SteNicholas/gravitino
that referenced
this issue
Feb 22, 2024
… handle an unresolvable type from the catalog
SteNicholas
added a commit
to SteNicholas/gravitino
that referenced
this issue
Feb 22, 2024
…o handle an unresolvable type from the catalog
SteNicholas
added a commit
to SteNicholas/gravitino
that referenced
this issue
Feb 22, 2024
…o handle an unresolvable type from the catalog
SteNicholas
added a commit
to SteNicholas/gravitino
that referenced
this issue
Feb 22, 2024
…o handle an unresolvable type from the catalog
SteNicholas
added a commit
to SteNicholas/gravitino
that referenced
this issue
Feb 22, 2024
…o handle an unresolvable type from the catalog
SteNicholas
added a commit
to SteNicholas/gravitino
that referenced
this issue
Feb 22, 2024
…o handle an unresolvable type from the catalog
SteNicholas
added a commit
to SteNicholas/gravitino
that referenced
this issue
Feb 22, 2024
…o handle an unresolvable type from the catalog
SteNicholas
added a commit
to SteNicholas/gravitino
that referenced
this issue
Feb 22, 2024
…o handle an unresolvable type from the catalog
SteNicholas
added a commit
to SteNicholas/gravitino
that referenced
this issue
Feb 22, 2024
…o handle an unresolvable type from the catalog
SteNicholas
added a commit
to SteNicholas/gravitino
that referenced
this issue
Feb 23, 2024
…o handle an unresolvable type from the catalog
SteNicholas
added a commit
to SteNicholas/gravitino
that referenced
this issue
Feb 23, 2024
…o handle an unresolvable type from the catalog
mchades
pushed a commit
that referenced
this issue
Feb 23, 2024
…le an unresolvable type from the catalog (#2140) ### What changes were proposed in this pull request? `Type` adds `UNPARSED` column data type to handle an unresolvable type from the catalog. ### Why are the changes needed? If a column data type in the catalog does not have a mapping in Gravitino, an exception will be thrown. We should map all data types from a catalog to Gravitino. However, in practical situations, loading exceptions may occur due to the addition of new data types or insufficient mapping support. Introduce `UnparsedType` to represent the unparsed data type. Fix: #2117 ### Does this PR introduce _any_ user-facing change? `Type` adds `UNKNOWN` column data type that represents an unresolvable type. ### How was this patch tested? - `TestJsonUtils#testTypeSerDe` - `TestTypes#testUnparsedType` - `TestTypeConverter#testTypeConverter` - `TestMysqlTypeConverter#testToGravitinoType` - `TestPostgreSqlTypeConverter#testToGravitinoType` - `CatalogMysqlIT#testUnparsedTypeConverter` - `CatalogPostgreSqlIT#testUnparsedTypeConverter`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What would you like to be improved?
If a column data type in the catalog does not have a mapping in Gravitino, an exception will be thrown.
Ideally, we should map all data types from a catalog to Gravitino. However, in practical situations, loading exceptions may occur due to the addition of new data types or insufficient mapping support.
How should we improve?
Add an
Unknowncolumn data type to handle an unresolvable type from the catalog, to ensure the table load successfullyThe text was updated successfully, but these errors were encountered: