[#1717] fix(jdbc-mysql): throw an exception if setting comment on MySQL database #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqi1129
reviewed
Jan 30, 2024
.../src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlDatabaseOperations.java
Outdated
Show resolved
Hide resolved
jerryshao
changed the title
jerryshao
reviewed
Jan 30, 2024
| String originComment = StringIdentifier.removeIdFromComment(comment); | ||
| if (StringUtils.isNotEmpty(originComment)) { | ||
| throw new UnsupportedOperationException( | ||
| "MySQL doesn't support set schema comment:" + originComment); |
There was a problem hiding this comment.
Can you please add a whitespace after ":"
jerryshao
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
throw a exception when user. set comment on MySQL database
Why are the changes needed?
Fix: #1717 #1767
Does this PR introduce any user-facing change?
yes, if user set comment on MySQL database, will throw a exception.
How was this patch tested?
add UT