You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
org.opentest4j.AssertionFailedError: expected: <comment> but was: <null>
at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1141)
at com.datastrato.gravitino.integration.test.catalog.jdbc.mysql.CatalogMysqlIT.testCreateAndLoadSchema(CatalogMysqlIT.java:579)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725)
at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
I suggest to add a check on comment, if user set MySQL schema comment, throw a exception instead of print a log and eat it. @jerryshao@Clearvive what do you think?
…QL database (#1784)
### What changes were proposed in this pull request?
throw a exception when user. set comment on MySQL database
### Why are the changes needed?
Fix: #1717#1767
### Does this PR introduce _any_ user-facing change?
yes, if user set comment on MySQL database, will throw a exception.
### How was this patch tested?
add UT
Version
main branch
Describe what's wrong
couldn't get schema comment from mysql catalog
Error message and/or stacktrace
How to reproduce
Additional context
No response
The text was updated successfully, but these errors were encountered: