[#1551] improve(server): Optimize the error message #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqqttt123
reviewed
Jan 22, 2024
server/src/main/java/com/datastrato/gravitino/server/web/rest/ExceptionHandlers.java
Outdated
Show resolved
Hide resolved
yuqi1129
reviewed
Jan 22, 2024
server/src/main/java/com/datastrato/gravitino/server/web/rest/ExceptionHandlers.java
Outdated
Show resolved
Hide resolved
|
@yuqi1129 @qqqttt123 please review again. |
mchades
pushed a commit
to mchades/gravitino
that referenced
this pull request
Jan 24, 2024
### What changes were proposed in this pull request? This PR optimize the error message to make it more meaningful to the UI. Previously it outputs the exception class name, which is not meaningful to users. Now change to the actual error message like below: ``` Failed to operate table(s) [ADMINISTRABLE_ROLE_AUTHORIZATIONS] operation [LOAD] under schema [information_schema], reason [Failed to parse create table information_schema.ADMINISTRABLE_ROLE_AUTHORIZATIONS SQL] ``` The reason field is only the error message now. ### Why are the changes needed? To make the error message on UI more meaningful. Fix: apache#1551 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Local verify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR optimize the error message to make it more meaningful to the UI.
Previously it outputs the exception class name, which is not meaningful to users. Now change to the actual error message like below:
The reason field is only the error message now.
Why are the changes needed?
To make the error message on UI more meaningful.
Fix: #1551
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Local verify.