Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] The API message should display slightly more complete content #1551

Closed
ch3yne opened this issue Jan 17, 2024 · 1 comment · Fixed by #1620
Closed

[Improvement] The API message should display slightly more complete content #1551

ch3yne opened this issue Jan 17, 2024 · 1 comment · Fixed by #1620
Assignees
@jerryshao
Labels
improvement Improvements on everything
Milestone
Gravitino 0.4.0

Comments

@ch3yne
Copy link
Contributor

ch3yne commented Jan 17, 2024

What would you like to be improved?

The API message only shows java class name on the message field, more info shows in stack field and the main information is on the first line.
The web UI only show text from the message field.

How should we improve?

I think we should show more complete content.
option 1: showing message plus the first line ofstack in the web UI.
option 2: join more complete content on the message field in the backend.
@ch3yne ch3yne added the improvement Improvements on everything label Jan 17, 2024
@jerryshao
Copy link
Contributor

I will handle this.

@jerryshao jerryshao self-assigned this Jan 19, 2024
@jerryshao jerryshao added this to the Gravitino 0.4.0 milestone Jan 19, 2024
@jerryshao jerryshao mentioned this issue Jan 19, 2024
Merged
jerryshao added a commit that referenced this issue Jan 24, 2024
@jerryshao
[#1551] improve(server): Optimize the error message (#1620)
0ec0d3d 
### What changes were proposed in this pull request?

This PR optimize the error message to make it more meaningful to the UI.

Previously it outputs the exception class name, which is not meaningful
to users. Now change to the actual error message like below:

```
Failed to operate table(s) [ADMINISTRABLE_ROLE_AUTHORIZATIONS] operation [LOAD] under schema [information_schema], reason [Failed to parse create table information_schema.ADMINISTRABLE_ROLE_AUTHORIZATIONS SQL]
```

The reason field is only the error message now.


### Why are the changes needed?

To make the error message on UI more meaningful.

Fix: #1551 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Local verify.
mchades pushed a commit to mchades/gravitino that referenced this issue Jan 24, 2024
@jerryshao @mchades
[apache#1551] improve(server): Optimize the error message (apache#1620)
b8fa890 
### What changes were proposed in this pull request?

This PR optimize the error message to make it more meaningful to the UI.

Previously it outputs the exception class name, which is not meaningful
to users. Now change to the actual error message like below:

```
Failed to operate table(s) [ADMINISTRABLE_ROLE_AUTHORIZATIONS] operation [LOAD] under schema [information_schema], reason [Failed to parse create table information_schema.ADMINISTRABLE_ROLE_AUTHORIZATIONS SQL]
```

The reason field is only the error message now.


### Why are the changes needed?

To make the error message on UI more meaningful.

Fix: apache#1551 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Local verify.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerryshao jerryshao

Labels
improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.4.0
Development

Successfully merging a pull request may close this issue.

[#1551] improve(server): Optimize the error message jerryshao/gravitino
2 participants
@jerryshao @ch3yne