-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1380] Add Literals class for managing the Literal helper methods #1381
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
api/src/main/java/com/datastrato/gravitino/rel/expressions/literals/Literal.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /* | ||
| * Copyright 2024 Datastrato Pvt Ltd. | ||
| * This software is licensed under the Apache License version 2. | ||
| */ | ||
| package com.datastrato.gravitino.rel.expressions.literals; | ||
|
|
||
| import com.datastrato.gravitino.rel.expressions.Expression; | ||
| import com.datastrato.gravitino.rel.types.Type; | ||
|
|
||
| /** | ||
| * Represents a constant literal value in the public expression API. | ||
| * | ||
| * @param <T> the JVM type of value held by the literal | ||
| */ | ||
| public interface Literal<T> extends Expression { | ||
| /** @return The literal value. */ | ||
| T value(); | ||
|
|
||
| /** @return The data type of the literal. */ | ||
| Type dataType(); | ||
|
|
||
| @Override | ||
| default Expression[] children() { | ||
| return EMPTY_EXPRESSION; | ||
| } | ||
| } |
87 changes: 87 additions & 0 deletions
87
api/src/main/java/com/datastrato/gravitino/rel/expressions/literals/Literals.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| /* | ||
| * Copyright 2024 Datastrato Pvt Ltd. | ||
| * This software is licensed under the Apache License version 2. | ||
| */ | ||
| package com.datastrato.gravitino.rel.expressions.literals; | ||
|
|
||
| import com.datastrato.gravitino.rel.types.Type; | ||
| import com.datastrato.gravitino.rel.types.Types; | ||
| import java.util.Objects; | ||
|
|
||
| /** The helper class to create literals to pass into Gravitino. */ | ||
| public class Literals { | ||
|
|
||
| /** | ||
| * Creates a literal with the given value and data type. | ||
| * | ||
| * @param value the literal value | ||
| * @param dataType the data type of the literal | ||
| * @return a new {@link com.datastrato.gravitino.rel.expressions.Literal} instance | ||
| * @param <T> the JVM type of value held by the literal | ||
| */ | ||
| public static <T> LiteralImpl<T> of(T value, Type dataType) { | ||
| return new LiteralImpl<>(value, dataType); | ||
| } | ||
|
|
||
| /** | ||
| * Creates an integer type literal with the given value. | ||
| * | ||
| * @param value the integer literal value | ||
| * @return a new {@link Literal} instance | ||
| */ | ||
| public static LiteralImpl<Integer> integer(Integer value) { | ||
| return of(value, Types.IntegerType.get()); | ||
| } | ||
|
|
||
| /** | ||
| * Creates a string type literal with the given value. | ||
| * | ||
| * @param value the string literal value | ||
| * @return a new {@link Literal} instance | ||
| */ | ||
| public static LiteralImpl<String> string(String value) { | ||
| return of(value, Types.StringType.get()); | ||
| } | ||
|
|
||
| /** | ||
| * Creates a literal with the given type value. | ||
| * | ||
| * @param <T> The JVM type of value held by the literal. | ||
| */ | ||
| public static final class LiteralImpl<T> implements Literal<T> { | ||
| private final T value; | ||
| private final Type dataType; | ||
|
|
||
| private LiteralImpl(T value, Type dataType) { | ||
| this.value = value; | ||
| this.dataType = dataType; | ||
| } | ||
|
|
||
| @Override | ||
| public T value() { | ||
| return value; | ||
| } | ||
|
|
||
| @Override | ||
| public Type dataType() { | ||
| return dataType; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (o == null || getClass() != o.getClass()) { | ||
| return false; | ||
| } | ||
| LiteralImpl<?> literal = (LiteralImpl<?>) o; | ||
| return Objects.equals(value, literal.value) && Objects.equals(dataType, literal.dataType); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(value, dataType); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you deprecate the class, not just the method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, I have moved this class from package
com.datastrato.gravitino.rel.expressionstocom.datastrato.gravitino.rel.expressions.literals, and I want users to use the new class.