[#1380] Add Literals class for managing the Literal helper methods #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should modify the document, too. |
jerryshao
reviewed
Jan 8, 2024
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
Why do you deprecate the class, not just the method?
There was a problem hiding this comment.
In fact, I have moved this class from package com.datastrato.gravitino.rel.expressions to com.datastrato.gravitino.rel.expressions.literals, and I want users to use the new class.
user doc will modify in another subtask, see task list of #1379. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
LiteralAPI deprecatedWhy are the changes needed?
Fix: #1380
Does this PR introduce any user-facing change?
Yes, make the old
LiteralAPI deprecatedHow was this patch tested?
existing tests