Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Improve English, use better names and data, simplify SQL #1272

Conversation

github-actions[bot]
Copy link

What changes were proposed in this pull request?

In general, it is better to use more realistic data and don't use generic names ending in numbers. The SQL also needs to match the amount of data we have in the playground.

Why are the changes needed?

To provide a slightly more realistic example and make SQL easier to understand.

Fix: # N/A

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

Ran commands locally to test.

### What changes were proposed in this pull request?

In general, it is better to use more realistic data and don't use
generic names ending in numbers. The SQL also needs to match the amount
of data we have in the playground.

### Why are the changes needed?

To provide a slightly more realistic example and make SQL easier to
understand.

Fix: # N/A

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Ran commands locally to test.
@github-actions github-actions bot added cherry-pick need backport Issues that need to backport to another branch labels Dec 28, 2023
@github-actions github-actions bot requested a review from jerryshao December 28, 2023 06:14
@jerryshao jerryshao closed this Dec 28, 2023
@jerryshao jerryshao reopened this Dec 28, 2023
@jerryshao jerryshao merged commit a0b5437 into branch-0.3 Dec 28, 2023
4 checks passed
@jerryshao jerryshao deleted the cherry-pick-branch-0.3-ad8d8ad9392d4463bc288215fdbb10d6131ece62 branch January 2, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants