[Minor] Improve English, use better names and data, simplify SQL #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmclean
changed the title
jerryshao
added
need backport
|
@qqqttt123 can you please help to review, thanks. |
qqqttt123
reviewed
Dec 27, 2023
qqqttt123
approved these changes
Dec 28, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Dec 28, 2023
### What changes were proposed in this pull request? In general, it is better to use more realistic data and don't use generic names ending in numbers. The SQL also needs to match the amount of data we have in the playground. ### Why are the changes needed? To provide a slightly more realistic example and make SQL easier to understand. Fix: # N/A ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Ran commands locally to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In general, it is better to use more realistic data and don't use generic names ending in numbers. The SQL also needs to match the amount of data we have in the playground.
Why are the changes needed?
To provide a slightly more realistic example and make SQL easier to understand.
Fix: # N/A
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Ran commands locally to test.