Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] improvement(docs): Optimize Trino related docs and fix some minor mistakes in docs #1152

Merged
merged 10 commits into from
Dec 14, 2023
Merged

[Minor] improvement(docs): Optimize Trino related docs and fix some minor mistakes in docs #1152

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b7792cd
Optimize trino related docs and fix some minor mistakes in docs
yuqi1129 Dec 14, 2023
8cea8d8
Merge branch 'main' of github.com:datastrato/graviton into minor
yuqi1129 Dec 14, 2023
15425e0
Fix discussion.
yuqi1129 Dec 14, 2023
8bbc13e
Fix discussion again.
yuqi1129 Dec 14, 2023
4eebf9b
Fix some syntax and spelling errors.
yuqi1129 Dec 14, 2023
26e7daf
Refine docs of Trino configuration.md
yuqi1129 Dec 14, 2023
357452f
Fix
yuqi1129 Dec 14, 2023
f724c81
Polish sentences again.
yuqi1129 Dec 14, 2023
e97319c
fix the syntax problem.
yuqi1129 Dec 14, 2023
5e28c2f
Merge branch 'main' into minor
yuqi1129 Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/trino-connector/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ license: "Copyright 2023 Datastrato Pvt Ltd.
This software is licensed under the Apache License version 2."
---

| Property | Type | Default Value | Description | Required | Since Version |
|--------------------|--------|-------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|----------|---------------|
| connector.name | string | gravitino | The `connector.name` defines the name of Gravitino connector, this value is always 'gravitino'. | Yes | 0.2.0 |
| gravitino.metalake | string | (none) | The `gravitino.metalake` defines the metalake used. You can create it beforehand or later on. If not set, Trino might throw an error upon startup. It must be set to a valid metalake name. If it's not created, the Gravitino connector continues checking until it's created. Once created, it will load the catalogs, schemas, and tables into Trino and maintain synchronization. | Yes | 0.2.0 |
| gravitino.url | string | http://localhost:8090 | The `gravitino.url` defines the connection URL for the Gravitino server. If not set, the default value is `http://localhost:8090`. If the Gravitino server is not starting, Trino can still start normally. Once the Gravitino server is up and running, the Gravitino connector will automatically connect. You can find error details in the Trino logs. | Yes | 0.2.0 |
| Property | Type | Default Value | Description | Required | Since Version |
|--------------------|--------|-----------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|----------|---------------|
| connector.name | string | (none) | The `connector.name` defines the name of Trino connector, this value is always 'gravitino'. | Yes | 0.2.0 |
| gravitino.metalake | string | (none) | The `gravitino.metalake` defines which metalake in Gravitino server the Trino connector uses. Trino connector should set it at start, the value of `gravitino.metalake` need to a valid name of metalake, no matter Gravitino has created it or not, once Trino connector successfully detect the existence of metalake, it will load all catalogs, schemas, and tables under this metalake automatically and keep synchronization. | Yes | 0.2.0 |
yuqi1129 marked this conversation as resolved.
Show resolved Hide resolved
| gravitino.url | string | http://localhost:8090 | The `gravitino.url` defines the connection URL of the Gravitino server, the default value is `http://localhost:8090`. If this Gravitino server has not started, Trino can still start and work normally. Once the Gravitino server is up and running, Trino connector will automatically connect to Gravitino sever and load metadata. | Yes | 0.2.0 |
yuqi1129 marked this conversation as resolved.
Show resolved Hide resolved
14 changes: 8 additions & 6 deletions docs/trino-connector/supported-catalog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,12 @@ The catalogs currently supported by the Gravitino connector are as follows:

## Create catalog

Trino currently does not support creating Gravitino managed catalogs.
If you need to create a catalog, please refer to:
- [Create a Catalog](../manage-metadata-using-gravitino.md#create-a-catalog)
Trino currently does not support creating Gravitino managed catalogs, if you need to create a catalog, please refer to: [Create a Catalog](../manage-metadata-using-gravitino.md#create-a-catalog).

## Data type mapping between Trino and Gravitino

All types of catalogs support the following data type conversions between Trino and Gravitino:
Gravitino connector supports the following data type conversions between Trino and Gravitino currently. Depending on the detailed catalog, Gravitino may not support some data types conversion for this specific catalog, for example,
Hive does not support `TIME` data type.

| Gravitino Type | Trino Type |
|----------------|------------|
Expand All @@ -36,8 +35,11 @@ All types of catalogs support the following data type conversions between Trino
| StringType | VARCHAR |
| VarcharType | VARCHAR |
| BinaryType | VARBINARY |
| TimestampType | TIMESTAMP |
| DateType | DATE |
| TimeType | TIME |
| TimestampType | TIMESTAMP |
| ArrayType | ARRAY |
| MapType | MAP |
| StructType | ROW |
| StructType | ROW |

For more about Trino data types, please refer to [Trino data types](https://trino.io/docs/current/language/types.html) and Gravitino data types, please refer to [Gravitino data types](../manage-metadata-using-gravitino.md#gravitino-table-column-type).