Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] improvement(docs): Optimize Trino related docs and fix some minor mistakes in docs #1152

Merged
merged 10 commits into from
Dec 14, 2023

Conversation

yuqi1129
Copy link
Contributor

What changes were proposed in this pull request?

Refine some descriptions and correct mistakes in Trino-related docs.

Why are the changes needed?

Make users more aware of the documents.

Does this PR introduce any user-facing change?

N/A.

How was this patch tested?

N/A.

@yuqi1129 yuqi1129 requested a review from diqiu50 December 14, 2023 02:37
@yuqi1129 yuqi1129 self-assigned this Dec 14, 2023
@yuqi1129 yuqi1129 added this to the Gravitino 0.4.0 milestone Dec 14, 2023
@jerryshao jerryshao added need backport Issues that need to backport to another branch branch-0.3 labels Dec 14, 2023
docs/trino-connector/supported-catalog.md Outdated Show resolved Hide resolved
docs/trino-connector/configuration.md Outdated Show resolved Hide resolved
@yuqi1129
Copy link
Contributor Author

Everything has been resolved.

diqiu50
diqiu50 previously approved these changes Dec 14, 2023
Copy link
Contributor

@diqiu50 diqiu50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerryshao
Copy link
Contributor

@yuqi1129 please rebase the code.

@yuqi1129
Copy link
Contributor Author

@yuqi1129 please rebase the code.

Done

@jerryshao jerryshao merged commit 4a3eca5 into apache:main Dec 14, 2023
4 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 14, 2023
…inor mistakes in docs (#1152)

### What changes were proposed in this pull request?

Refine some descriptions and correct mistakes in Trino-related docs.

### Why are the changes needed?

Make users more aware of the documents.

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

N/A.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants