Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Add property & config system support for Catalog #415

Closed
jerryshao opened this issue Sep 18, 2023 · 2 comments · Fixed by #452
Closed

[EPIC] Add property & config system support for Catalog #415

jerryshao opened this issue Sep 18, 2023 · 2 comments · Fixed by #452
Assignees

Comments

@jerryshao
Copy link
Contributor

Describe the proposal

This issue tracks the work of designing and implementing a decent property & config system for Graviton's Catalog.

Unlike Trino, in which the catalog system is configurable, Graviton's catalog is creatable, so we should have a mechanism to configure the catalog when creating through catalog property and configuration.

What we could refer is Trino, but we can also refer to other systems.

Task list

No response

@jerryshao
Copy link
Contributor Author

@yuqi1129 assigned this to you.

@jerryshao jerryshao added this to the Graviton v0.2.0 milestone Sep 18, 2023
@yuqi1129
Copy link
Contributor

jerryshao pushed a commit that referenced this issue Oct 8, 2023
…r catalog (#452)

### What changes were proposed in this pull request?

1. Add property validation logic for catalog
2. Move property validation code for tables to  `PropertiesMetadata`
3. Fix some typo problem.

### Why are the changes needed?

Currently, we have not verified the accuracy of the properties when
creating/altering catalogs, which is very risky and tends to be buggy.


Fix: #415 

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

Add `TestPropertyMeta` and `TestPropertyValidator`
Clearvive pushed a commit that referenced this issue Oct 17, 2023
…r catalog (#452)

### What changes were proposed in this pull request?

1. Add property validation logic for catalog
2. Move property validation code for tables to  `PropertiesMetadata`
3. Fix some typo problem.

### Why are the changes needed?

Currently, we have not verified the accuracy of the properties when
creating/altering catalogs, which is very risky and tends to be buggy.


Fix: #415 

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

Add `TestPropertyMeta` and `TestPropertyValidator`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment