Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] add properties validate check when create&alter catalog properties. #362

Closed
FANNG1 opened this issue Sep 8, 2023 · 1 comment · Fixed by #473
Closed

[Improvement] add properties validate check when create&alter catalog properties. #362

FANNG1 opened this issue Sep 8, 2023 · 1 comment · Fixed by #473
Assignees
@yuqi1129
Labels
duplicate This issue or pull request already exists improvement Improvements on everything
Milestone
Graviton v0.2.0

Comments

@FANNG1
Copy link
Contributor

FANNG1 commented Sep 8, 2023

What would you like to be improved?

some properties are critical for graviton catalogs, such as provider, hive metastore uri for HiveCatalog, Iceberg catalog type for IcebergCatalog, these properties should't be changed or we may encounter unexpected problems.

How should we improve?

No response
@FANNG1 FANNG1 added the improvement Improvements on everything label Sep 8, 2023
@yuqi1129 yuqi1129 mentioned this issue Sep 13, 2023
Merged
@jerryshao
Copy link
Contributor

I think this is related to #415 , @sandflee assigned to you to handle it overall.

@jerryshao jerryshao added this to the Graviton v0.2.0 milestone Sep 25, 2023
@yuqi1129 yuqi1129 mentioned this issue Oct 12, 2023
Merged
@jerryshao jerryshao added the duplicate This issue or pull request already exists label Oct 12, 2023
@jerryshao jerryshao closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2023
jerryshao pushed a commit that referenced this issue Oct 13, 2023
@yuqi1129
[#470] feat(hive): Support detailed hive catalog property metadata (#473
616d50e 
)

### What changes were proposed in this pull request?

Implement `catalogPropertiesMetadata` for `HiveCatalogOperations`

### Why are the changes needed?

Currently `catalogPropertiesMetadata` will return an empty map, and we
need to implement it to return a real value for the hive property
metadata.


Fix: #470 
Fix: #362 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Add test `testCatalogProperty` in `TestHiveCatalog`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuqi1129 yuqi1129

Labels
duplicate This issue or pull request already exists improvement Improvements on everything
Projects
None yet
Milestone
Graviton v0.2.0
Development

Successfully merging a pull request may close this issue.

[#470] feat(hive): Support detailed hive catalog property metadata yuqi1129/graviton
3 participants
@jerryshao @FANNG1 @yuqi1129