[FLINK-34333][k8s] 1.18 backport of FLINK-34007 #24245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…@AfterEach methods
…e rely on a BlockingQueue This allows us to wait for tasks to "arrive".
…calls This way, we can use FlinkAssertions#assertThatFuture and use assertion messages instead of comments.
…#run() call (cherry-picked from FLINK-34007) v5.12.4 allowed us to reuse the LeaderElector. With v6.6.2 (fabric8io/kubernetes-client#4125) this behavior changed. One LeaderElector can only be used until the leadership is lost. An ITCase is added to cover the scenario where the leadership is lost.
…pache#5464 (cherry-picked from FLINK-34007) fabric8io/kubernetes-client#5463 The change in KubernetesClientTestBase was necessary because of the change [apache#5369](fabric8io/kubernetes-client#5369) that ended up in v6.9.0 as well.
gyfora
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This is the fix of FLINK-34007 applied to Flink 1.18. In the end, it's a straight-forward backport including the upgrade to fabric8io:kubernetes-client v6.9.0. See FLINK-34333 for further details on the discussion whether the dependency upgrade is suitable.
Brief change log
KubernetesLeaderElectorre-instantiate the fabric8io LeaderElector at the beginning of a new leadership lifecycle.fabric8io:kubernetes-clientfromv6.6.2tov6.9.0in order to include LeaderElector doesn't call onStopLeading fabric8io/kubernetes-client#5463Verifying this change
KubernetesLeaderElectorITCaseto include a test case for the scenario that was revealed in FLINK-34007 and a check that verifies the leadership lost event being sent when stopping theKubernetesLeaderElectorDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation