Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for new list options #5369

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

shawkins
Copy link
Contributor

Description

Since we directly expose ListOptions, it's good to keep it up-to-date - to future-proof it logic was switched to serialization. This accounts for several missing properties including includeInitialEvents and resourceVersionMatch.

Closes #5368

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.9.0 milestone Aug 1, 2023
@manusa manusa merged commit 3051d11 into fabric8io:main Aug 1, 2023
XComp added a commit to XComp/flink that referenced this pull request Feb 1, 2024
…pache#5464 (cherry-picked from FLINK-34007)

fabric8io/kubernetes-client#5463

The change in KubernetesClientTestBase was necessary because of the change [apache#5369](fabric8io/kubernetes-client#5369) that ended up in v6.9.0 as well.
XComp added a commit to XComp/flink that referenced this pull request Feb 1, 2024
…pache#5464 (cherry-picked from FLINK-34007)

fabric8io/kubernetes-client#5463

The change in KubernetesClientTestBase was necessary because of the change [apache#5369](fabric8io/kubernetes-client#5369) that ended up in v6.9.0 as well.
XComp added a commit to XComp/flink that referenced this pull request Feb 5, 2024
…pache#5464 (cherry-picked from FLINK-34007)

fabric8io/kubernetes-client#5463

The change in KubernetesClientTestBase was necessary because of the change [apache#5369](fabric8io/kubernetes-client#5369) that ended up in v6.9.0 as well.
XComp added a commit to XComp/flink that referenced this pull request Feb 7, 2024
…pache#5464 (cherry-picked from FLINK-34007)

fabric8io/kubernetes-client#5463

The change in KubernetesClientTestBase was necessary because of the change [apache#5369](fabric8io/kubernetes-client#5369) that ended up in v6.9.0 as well.
XComp added a commit to apache/flink that referenced this pull request Feb 13, 2024
…5464 (cherry-picked from FLINK-34007)

fabric8io/kubernetes-client#5463

The change in KubernetesClientTestBase was necessary because of the change [#5369](fabric8io/kubernetes-client#5369) that ended up in v6.9.0 as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KubernetesClient does not use sendInitialEvents for watching
2 participants