Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-1698] Enhance the test coverage part-19 : dubbo-rpc/dubbo-rpc-thrift module #2042

Merged
merged 2 commits into from
Jul 9, 2018

Conversation

kimmking
Copy link
Member

@kimmking kimmking commented Jul 6, 2018

What is the purpose of the change

[Dubbo-1698] Enhance the test coverage part-19 : dubbo-rpc/dubbo-rpc-thrift module

Brief changelog

[Dubbo-1698] Enhance the test coverage part-19 : dubbo-rpc/dubbo-rpc-thrift module

Verifying this change

test coverage enhance in codecov.io

fixed #1698

@lovepoem
Copy link
Member

lovepoem commented Jul 6, 2018

👍

@codecov-io
Copy link

Codecov Report

Merging #2042 into master will increase coverage by 0.81%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2042      +/-   ##
============================================
+ Coverage     52.14%   52.96%   +0.81%     
- Complexity     4960     4977      +17     
============================================
  Files           568      568              
  Lines         25453    25453              
  Branches       4486     4486              
============================================
+ Hits          13273    13480     +207     
+ Misses        10153     9923     -230     
- Partials       2027     2050      +23
Impacted Files Coverage Δ Complexity Δ
...he/dubbo/remoting/transport/netty/NettyClient.java 72.88% <0%> (-8.48%) 12% <0%> (-1%)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 77.77% <0%> (-5.56%) 5% <0%> (-1%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.25% <0%> (-5%) 22% <0%> (-1%)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 8% <0%> (-1%)
...e/dubbo/remoting/transport/netty4/NettyServer.java 72.13% <0%> (-3.28%) 9% <0%> (-1%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 87.85% <0%> (-1.87%) 15% <0%> (ø)
...ache/dubbo/remoting/transport/mina/MinaClient.java 56.92% <0%> (-1.54%) 8% <0%> (-1%)
...bo/remoting/transport/netty/NettyCodecAdapter.java 54.68% <0%> (+1.56%) 3% <0%> (ø) ⬇️
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 55.69% <0%> (+3.79%) 13% <0%> (+2%) ⬆️
.../apache/dubbo/rpc/protocol/thrift/ThriftUtils.java 91.8% <0%> (+16.39%) 8% <0%> (+2%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b36a6ee...52d3840. Read the comment docs.

@lovepoem lovepoem merged commit ef78bbd into apache:master Jul 9, 2018
July-X pushed a commit to July-X/dubbo that referenced this pull request Jul 12, 2018
* commit 'b055991b317f4e58d256721875a00c52fe415510': (271 commits)
  Merge pull request apache#1957, enhancements for the new async way of Dubbo.
  rename log file from alibaba to custom-access (apache#2057)
  Merge pull request apache#2049, upgrade netty4 to the latest release and make it the default option for transporter.
  Format style.
  Restore the badges in README.
  Polish README.
  Refactor README.
  Merge pull request apache#2047, deprecate dubbo-rpc-thrift.
  Merge pull request apache#2005, change maven parent from sonatype to apache.
  rename access log in unit test from 'alibaba' to 'alibaba.log' so that it cannot be committed by accident. (apache#2051)
  add test cases for injvm rpc protocol (apache#2041)
  add test cases for rpc thrift protocol (apache#2042)
  Merge pull request apache#1966, introduces dubbo metrics API module.
  [Dubbo- unit test class not found] fix class not found "hi" (apache#2034)
  add README for compatible module (apache#2019)
  Polish README.
  update README (apache#2025)
  [Dubbo-1695] Enhance the test coverage part-16 : dubbo-rpc/dubbo-rpc-api  module (apache#2004)
  Merge pull request apache#1997, clienthandler in netty4 should trigger heartbeat handler.
  Update issue template description.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance the test coverage part-19 : dubbo-rpc/dubbo-rpc-rmi(dubbo-rpc-thrift|dubbo-rpc-webservice) modules
3 participants