Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo- unit test class not found] fix class not found "hi" #2034

Merged
merged 2 commits into from
Jul 5, 2018

Conversation

zonghaishang
Copy link
Member

What is the purpose of the change

fix unit test DubboInvokerAvilableTest & DubboLazyConnectTest class not found "hi"

Brief changelog

  1. Replace url path "hi" to "org.apache.dubbo.rpc.protocol.dubbo.IDemoService"
  2. Move "org.apache.dubbo.rpc.protocol.dubbo.IDemoService" to the top

Verifying this change

unit test passed

Follow this checklist to help us incorporate your contribution quickly and easily:

  • [] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #2034 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2034      +/-   ##
============================================
- Coverage     52.16%   52.14%   -0.02%     
  Complexity     4904     4904              
============================================
  Files           562      562              
  Lines         25216    25216              
  Branches       4449     4449              
============================================
- Hits          13153    13150       -3     
- Misses        10060    10062       +2     
- Partials       2003     2004       +1
Impacted Files Coverage Δ Complexity Δ
.../dubbo/remoting/transport/netty4/NettyChannel.java 60% <0%> (-6.25%) 21% <0%> (-2%)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 55.69% <0%> (+3.79%) 13% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bed691b...e0a3fc2. Read the comment docs.

@qinliujie qinliujie merged commit 9e5d3bf into apache:master Jul 5, 2018
@zonghaishang zonghaishang deleted the refactor_unit_test branch July 6, 2018 02:23
July-X pushed a commit to July-X/dubbo that referenced this pull request Jul 12, 2018
* commit 'b055991b317f4e58d256721875a00c52fe415510': (271 commits)
  Merge pull request apache#1957, enhancements for the new async way of Dubbo.
  rename log file from alibaba to custom-access (apache#2057)
  Merge pull request apache#2049, upgrade netty4 to the latest release and make it the default option for transporter.
  Format style.
  Restore the badges in README.
  Polish README.
  Refactor README.
  Merge pull request apache#2047, deprecate dubbo-rpc-thrift.
  Merge pull request apache#2005, change maven parent from sonatype to apache.
  rename access log in unit test from 'alibaba' to 'alibaba.log' so that it cannot be committed by accident. (apache#2051)
  add test cases for injvm rpc protocol (apache#2041)
  add test cases for rpc thrift protocol (apache#2042)
  Merge pull request apache#1966, introduces dubbo metrics API module.
  [Dubbo- unit test class not found] fix class not found "hi" (apache#2034)
  add README for compatible module (apache#2019)
  Polish README.
  update README (apache#2025)
  [Dubbo-1695] Enhance the test coverage part-16 : dubbo-rpc/dubbo-rpc-api  module (apache#2004)
  Merge pull request apache#1997, clienthandler in netty4 should trigger heartbeat handler.
  Update issue template description.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants