Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge dubbo-rpc-xmlrpc into incubator-dubbo #3764

Closed
ralf0131 opened this issue Mar 28, 2019 · 4 comments
Closed

Merge dubbo-rpc-xmlrpc into incubator-dubbo #3764

ralf0131 opened this issue Mar 28, 2019 · 4 comments
Labels
help wanted Everything needs help from contributors

Comments

@ralf0131
Copy link
Contributor

Merge the code in https://github.com/dubbo/dubbo-rpc-xmlrpc into incubator-dubbo
@ralf0131 ralf0131 added help wanted Everything needs help from contributors ecosystem labels Mar 28, 2019
danielamorais added a commit to danielamorais/dubbo that referenced this issue Mar 29, 2019
@danielamorais
Merge dubbo-rpc-xmlrpc (apache#3764)
5e9701f
@danielamorais
Copy link

Should I add as a dependency in dubbo-all, right? I did it and I changed the name of the package for org.apache.dubbo (previously was io.github.kimmking) but there's no snapshot in https://repository.apache.org/content/groups/snapshots/org/apache/dubbo/ and this is why the build is failing.

Can u help me?

@ralf0131
Copy link
Contributor Author

What is the exact error you got?

@danielamorais
Copy link

The error was:

Could not resolve dependencies for project org.apache.dubbo:dubbo:jar:2.7.2-SNAPSHOT: Failure to find org.apache.dubbo:dubbo-rpc-xmlrpc:jar:2.7.2-SNAPSHOT in https://repository.apache.org/snapshots was cached in the local repository, resolution will not be reattempted until the update interval of apache.snapshots has elapsed or updates are forced

I made a lot of confusion, I was needed:

  • rename packages from "com.alibaba" to "org.apache"
  • add xmlrpc as a module in pom.xml of dubbo-rpc

I fixed it. Could u please review my PR? I'm not sure if everything is ok

@danielamorais danielamorais mentioned this issue May 12, 2019
Merged
6 tasks
ralf0131 pushed a commit that referenced this issue May 14, 2019
@ralf0131
[Dubbo-3764]Merge dubbo rpc xmlrpc (#3764) (#3775)
6ca5a10 
* Create constants for 'hash.names' and 'hash.arguments' (#3744)
* Merge dubbo-rpc-xmlrpc (#3764)
* Removing .gitignore
* Rename package name
* Add Apache License
* Rename groupID name and url
* Update dubbo-rpc-xmlrpc version and add as a dependency in dubbo-all
* Replace package for "org.apache.dubbo.xml" and rename "com.alibaba.*" to "org.apache.dubbo"
* Fix the name of artifactID
* Remove unused files and add dubbo-rpc-xml as a module in dubbo-rpc
* Remove authors and delete files that are duplicate in the main repo have one
* Fix the name of package and remove unnecessary space
* Remove unnecessary space
* Remove authors
* Fix imports and remove authors from pom
* Update groupID and the name of package
* Remove unused tags
* Add dubbo-rpc-xml as a dependency on dubbo-bom
* Fix package names
* Call JettyHttpBinder from remoting module to avoid duplicated files
* Fix unit tests and upgrade to JUnit 5
* Call JettyHttpBinder from remoting module to avoid duplicated files
* Add external dependencies on dubbo-dependencies-bom
@ralf0131
Copy link
Contributor Author

This will be available from 2.7.2 onwards.

@dubbo-bot dubbo-bot mentioned this issue May 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Everything needs help from contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ralf0131 @danielamorais