Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

应该使用常量代替 #3744

Closed
li1135759862 opened this issue Mar 27, 2019 · 0 comments · Fixed by #3758
Closed

应该使用常量代替 #3744

li1135759862 opened this issue Mar 27, 2019 · 0 comments · Fixed by #3758
Labels
help wanted Everything needs help from contributors

Comments

@li1135759862
Copy link

dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/loadbalance/
ConsistentHashLoadBalance.java
image
我看其他地方都是用Constants进行替换，这里是不是可以使用Constants类里的属性进行替换
@kezhenxu94 kezhenxu94 added help wanted Everything needs help from contributors good first issue labels Mar 27, 2019
danielamorais added a commit to danielamorais/dubbo that referenced this issue Mar 27, 2019
@danielamorais
Create constants for 'hash.names' and 'hash.arguments' (apache#3744)
56af21b
@danielamorais danielamorais mentioned this issue Mar 28, 2019
Merged
6 tasks
kexianjun pushed a commit that referenced this issue Mar 28, 2019
@kexianjun
Create constants for 'hash.names' and 'hash.arguments' (#3744) (#3758)
fca31c4
@dubbo-bot dubbo-bot mentioned this issue Mar 29, 2019
Closed
ralf0131 pushed a commit that referenced this issue May 14, 2019
@ralf0131
[Dubbo-3764]Merge dubbo rpc xmlrpc (#3764) (#3775)
6ca5a10 
* Create constants for 'hash.names' and 'hash.arguments' (#3744)
* Merge dubbo-rpc-xmlrpc (#3764)
* Removing .gitignore
* Rename package name
* Add Apache License
* Rename groupID name and url
* Update dubbo-rpc-xmlrpc version and add as a dependency in dubbo-all
* Replace package for "org.apache.dubbo.xml" and rename "com.alibaba.*" to "org.apache.dubbo"
* Fix the name of artifactID
* Remove unused files and add dubbo-rpc-xml as a module in dubbo-rpc
* Remove authors and delete files that are duplicate in the main repo have one
* Fix the name of package and remove unnecessary space
* Remove unnecessary space
* Remove authors
* Fix imports and remove authors from pom
* Update groupID and the name of package
* Remove unused tags
* Add dubbo-rpc-xml as a dependency on dubbo-bom
* Fix package names
* Call JettyHttpBinder from remoting module to avoid duplicated files
* Fix unit tests and upgrade to JUnit 5
* Call JettyHttpBinder from remoting module to avoid duplicated files
* Add external dependencies on dubbo-dependencies-bom
ralf0131 pushed a commit that referenced this issue Jul 3, 2019
@ralf0131
Refactor MetricsFilterTest to use Mockito (#4398)
4c4b931 
* Create constants for 'hash.names' and 'hash.arguments' (#3744)
* Fix conflicts of cherry-pick
* Add builder class for unit test
* Fix builder class
* Add apache license
beiwei30 pushed a commit that referenced this issue Jul 17, 2019
@beiwei30
[DUBBO-2991][WIP]Enhance the java doc of dubbo-cluster (#2991) (#4424)
63d33d1 
* Replace RpcStatus to count (#2984)

* Create constants for 'hash.names' and 'hash.arguments' (#3744)

* Add javadoc in RandomLoadBalance

* Improve Javadoc of RandomLoadBalance
rolandhe pushed a commit to rolandhe/dubbo that referenced this issue Sep 9, 2019
@rolandhe
Refactor MetricsFilterTest to use Mockito (apache#4398)
1cabc9f 
* Create constants for 'hash.names' and 'hash.arguments' (apache#3744)
* Fix conflicts of cherry-pick
* Add builder class for unit test
* Fix builder class
* Add apache license
rolandhe pushed a commit to rolandhe/dubbo that referenced this issue Sep 9, 2019
@rolandhe
Refactor MetricsFilterTest to use Mockito (apache#4398)
b4822b9 
* Create constants for 'hash.names' and 'hash.arguments' (apache#3744)
* Fix conflicts of cherry-pick
* Add builder class for unit test
* Fix builder class
* Add apache license
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Everything needs help from contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dubbo-3744]Create constants for 'hash.names' and 'hash.arguments' (#3744) danielamorais/dubbo
2 participants
@kezhenxu94 @li1135759862