Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Make sketch encoding configurable #17153

Merged
merged 1 commit into from
Sep 30, 2024
Merged

[Backport] Make sketch encoding configurable #17153

merged 1 commit into from
Sep 30, 2024

Conversation

adarshsanjeev
Copy link
Contributor

@adarshsanjeev adarshsanjeev commented Sep 25, 2024 •
edited
Loading

Backport of #17086

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@adarshsanjeev
Make sketch encoding configurable (apache#17086)
db11443 
Makes sketch encoding in MSQ configurable by the user. This would allow a user to configure the sketch encoding method for a specific query.

The default is octet stream encoding.
@adarshsanjeev adarshsanjeev added this to the 31.0.0 milestone Sep 25, 2024
@github-actions github-actions bot added Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Sep 25, 2024
@adarshsanjeev adarshsanjeev changed the title Make sketch encoding configurable (#17086) [Backport] Make sketch encoding configurable Sep 25, 2024
@kfaraz kfaraz merged commit e364d84 into apache:31.0.0 Sep 30, 2024
56 checks passed
@kfaraz kfaraz mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfaraz kfaraz kfaraz approved these changes

Assignees
No one assigned
Labels
Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Backport
Projects
None yet
Milestone
31.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adarshsanjeev @kfaraz