Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sketch encoding configurable #17086

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Make sketch encoding configurable #17086

merged 2 commits into from
Sep 25, 2024

Conversation

adarshsanjeev
Copy link
Contributor

@adarshsanjeev adarshsanjeev commented Sep 17, 2024 •
edited
Loading

Makes sketch encoding in MSQ configurable by the user. This would allow a user to configure the sketch encoding method for a specific query.

The default is octet stream encoding.

Release notes

  • Add a sketchEncoding query context parameter that controls the sketch encoding format between workers in MSQ. Allowed values are JSON or OCTET_STREAM. The default value is OCTET_STREAM.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions bot added Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Sep 17, 2024
@cryptoe cryptoe added this to the 31.0.0 milestone Sep 24, 2024
@adarshsanjeev adarshsanjeev merged commit 464b153 into apache:master Sep 25, 2024
56 checks passed
adarshsanjeev added a commit to adarshsanjeev/druid that referenced this pull request Sep 25, 2024
@adarshsanjeev
Make sketch encoding configurable (apache#17086)
db11443 
Makes sketch encoding in MSQ configurable by the user. This would allow a user to configure the sketch encoding method for a specific query.

The default is octet stream encoding.
@adarshsanjeev adarshsanjeev mentioned this pull request Sep 25, 2024
Merged
10 tasks
kfaraz pushed a commit to kfaraz/druid that referenced this pull request Sep 30, 2024
@adarshsanjeev @kfaraz
Make sketch encoding configurable (apache#17086)
23519a1 
Makes sketch encoding in MSQ configurable by the user. This would allow a user to configure the sketch encoding method for a specific query.

The default is octet stream encoding.
@kfaraz kfaraz mentioned this pull request Sep 30, 2024
Closed
kfaraz pushed a commit that referenced this pull request Sep 30, 2024
@adarshsanjeev
[Backport] Make sketch encoding configurable (#17086) (#17153)
e364d84 
Makes sketch encoding in MSQ configurable by the user. This would allow a user to configure the sketch encoding method for a specific query.

The default is octet stream encoding.
@kfaraz kfaraz mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptoe cryptoe cryptoe approved these changes

Assignees
No one assigned
Labels
Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262
Projects
None yet
Milestone
31.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adarshsanjeev @cryptoe