Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message when partition space is exhausted #15685

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Better error message when partition space is exhausted #15685

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5622a48
Better error message when partition space is exhausted
AmatyaAvadhanula Jan 15, 2024
7e22d83
Improve error message
AmatyaAvadhanula Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions processing/src/main/java/org/apache/druid/timeline/partition/OvershadowableManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,9 +403,9 @@ private Iterator<Entry<RootPartitionRange, Short2ObjectSortedMap<AtomicUpdateGro
TreeMap<RootPartitionRange, Short2ObjectSortedMap<AtomicUpdateGroup<T>>> stateMap
)
{
final RootPartitionRange lowFench = new RootPartitionRange((short) 0, (short) 0);
final RootPartitionRange lowFence = new RootPartitionRange((short) 0, (short) 0);
final RootPartitionRange highFence = new RootPartitionRange(partitionId, partitionId);
return stateMap.subMap(lowFench, false, highFence, false).descendingMap().entrySet().iterator();
return stateMap.subMap(lowFence, false, highFence, false).descendingMap().entrySet().iterator();
}

/**
Expand All @@ -418,9 +418,14 @@ private Iterator<Entry<RootPartitionRange, Short2ObjectSortedMap<AtomicUpdateGro
TreeMap<RootPartitionRange, Short2ObjectSortedMap<AtomicUpdateGroup<T>>> stateMap
)
{
final RootPartitionRange lowFench = new RootPartitionRange(partitionId, partitionId);
final RootPartitionRange lowFence = new RootPartitionRange(partitionId, partitionId);
final RootPartitionRange highFence = new RootPartitionRange(Short.MAX_VALUE, Short.MAX_VALUE);
return stateMap.subMap(lowFench, false, highFence, false).entrySet().iterator();
if (lowFence.compareTo(highFence) > 0) {
throw new ISE("PartitionId[%d] must be in the range [0, 32767]. "
+ "Try compacting the interval to reduce the segment count.", Short.toUnsignedInt(partitionId));
} else {
return stateMap.subMap(lowFence, false, highFence, false).entrySet().iterator();
}
}

/**
Expand Down
Loading