Better error message when partition space is exhausted #15685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfaraz
reviewed
Jan 15, 2024
| final RootPartitionRange highFence = new RootPartitionRange(Short.MAX_VALUE, Short.MAX_VALUE); | ||
| return stateMap.subMap(lowFench, false, highFence, false).entrySet().iterator(); | ||
| if (lowFence.compareTo(highFence) > 0) { | ||
| throw new ISE("PartitionId[%d] must be in the range [0, 32767].", Short.toUnsignedInt(partitionId)); |
There was a problem hiding this comment.
The message might still not be very useful because the user cannot determine the root cause. Maybe indicate the fact that there are too many partitions (i.e. more than 32,767) in the interval causing overflow of the partition ID range.
| if (lowFence.compareTo(highFence) > 0) { | ||
| throw new ISE("PartitionId[%d] must be in the range [0, 32767].", Short.toUnsignedInt(partitionId)); | ||
| } | ||
| return stateMap.subMap(lowFence, false, highFence, false).entrySet().iterator(); |
There was a problem hiding this comment.
Nit: Cleaner to put this in the else of the preceding if.
kfaraz
approved these changes
Jan 16, 2024
|
Merging since the failing UT is unrelated |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Segment locking introduced a limitation where the partition id of a segment must lie within [0, 32767]. When the partitionId falls outside this range, a cryptic error
fromKey > toKeycan be thrown.This PR is an attempt to improve the error message when the partition space is exhausted.
This PR has: